Skip to content

Update AdjacentPairs implementations and tests #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timvermeulen merged 3 commits into from
May 5, 2021
Merged

Update AdjacentPairs implementations and tests #139

timvermeulen merged 3 commits into from
May 5, 2021

Conversation

@natecook1000
Copy link
Member

@natecook1000 natecook1000 commented May 5, 2021

Update the AdjacentPairs implementation based on code review in #119.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@natecook1000 natecook1000 requested a review from timvermeulen May 5, 2021 04:42
timvermeulen
timvermeulen reviewed May 5, 2021
View reviewed changes
timvermeulen
timvermeulen reviewed May 5, 2021
View reviewed changes
@natecook1000
Copy link
Member Author

natecook1000 commented May 5, 2021

@swift-ci Please test

@timvermeulen
Copy link
Contributor

timvermeulen commented May 5, 2021

🎉

@timvermeulen timvermeulen merged commit 65ef6cb into main May 5, 2021
@timvermeulen timvermeulen deleted the nate/pairs branch May 5, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@timvermeulen timvermeulen timvermeulen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@natecook1000 @timvermeulen