Skip to content

Conversation

@0xTim
Copy link
Contributor

@0xTim 0xTim commented Nov 9, 2023

Update library to use the new JWTKit 5

Builds on top of #13 so that should be merged first

@0xTim
Copy link
Contributor Author

0xTim commented Nov 9, 2023

cc @ptoffy

@alexanderjordanbaker
Copy link
Collaborator

@0xTim Are you still planning to move this PR from Draft -> Ready?

@0xTim
Copy link
Contributor Author

0xTim commented Jan 30, 2024

@alexanderjordanbaker yes we will do once we have a release of the new version of JWTKit with a stable API

@0xTim
Copy link
Contributor Author

0xTim commented Feb 27, 2024

@alexanderjordanbaker this is pretty much ready. I don't know whether you want to wait until JWTKit v5 is out of Beta or you're happy to take it as is. We're not anticipating any API changes

@0xTim
Copy link
Contributor Author

0xTim commented Mar 14, 2024

@ptoffy FYI some conflicts here (also we should have a discussion about the Sendable stuff)

@alexanderjordanbaker
Copy link
Collaborator

@0xTim We would prefer to wait until the underlying software is out of beta before merging

@0xTim
Copy link
Contributor Author

0xTim commented Jun 26, 2024

@alexanderjordanbaker yep fully agree, we're planning on tagging a stable release pretty soon

@ptoffy want to tag an RC of JWTKit and fix the conflicts?

@ptoffy
Copy link
Contributor

ptoffy commented Jul 4, 2024

@0xTim done

@ptoffy
Copy link
Contributor

ptoffy commented Oct 5, 2024

JWTKit 5 is out so this should be ready cc @0xTim

@0xTim
Copy link
Contributor Author

0xTim commented Oct 5, 2024

@ptoffy can we bump this to Swift 6?

@0xTim 0xTim marked this pull request as ready for review October 5, 2024 20:40
@0xTim
Copy link
Contributor Author

0xTim commented Oct 7, 2024

@alexanderjordanbaker this should be ready to go now

@PWrzesinski
Copy link

Hello @alexanderjordanbaker, could this one be prioritized? Currently encountering an issue with JWTKit 4 and this is blocking me from upgrading. Thanks!

@alexanderjordanbaker
Copy link
Collaborator

This was completed @dimitribouniol's PR, closing as this library upgrade is complete

@0xTim
Copy link
Contributor Author

0xTim commented Jul 1, 2025

@ptoffy do you want to take a look at this and see if there's any improvements that can be made to avoid duplicating all the certificate verification code from JWTKit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants