-
Notifications
You must be signed in to change notification settings - Fork 50
Update to JWTKit 5 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @ptoffy |
|
@0xTim Are you still planning to move this PR from Draft -> Ready? |
|
@alexanderjordanbaker yes we will do once we have a release of the new version of JWTKit with a stable API |
|
@alexanderjordanbaker this is pretty much ready. I don't know whether you want to wait until JWTKit v5 is out of Beta or you're happy to take it as is. We're not anticipating any API changes |
|
@ptoffy FYI some conflicts here (also we should have a discussion about the Sendable stuff) |
|
@0xTim We would prefer to wait until the underlying software is out of beta before merging |
|
@alexanderjordanbaker yep fully agree, we're planning on tagging a stable release pretty soon @ptoffy want to tag an RC of JWTKit and fix the conflicts? |
|
@0xTim done |
|
JWTKit 5 is out so this should be ready cc @0xTim |
|
@ptoffy can we bump this to Swift 6? |
|
@alexanderjordanbaker this should be ready to go now |
|
Hello @alexanderjordanbaker, could this one be prioritized? Currently encountering an issue with JWTKit 4 and this is blocking me from upgrading. Thanks! |
|
This was completed @dimitribouniol's PR, closing as this library upgrade is complete |
|
@ptoffy do you want to take a look at this and see if there's any improvements that can be made to avoid duplicating all the certificate verification code from JWTKit? |
Update library to use the new JWTKit 5
Builds on top of #13 so that should be merged first