-
Notifications
You must be signed in to change notification settings - Fork 54
Add proxy support to AppStoreServerAPIClient #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Symars
wants to merge
1
commit into
apple:main
Choose a base branch
from
Symars:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,45 @@ public AppStoreServerAPIClient(BearerTokenAuthenticatorInterface bearerTokenAuth | |
| this.urlBase = HttpUrl.parse(this.url); | ||
| } | ||
|
|
||
| /** | ||
| * Create an App Store Server API client with a custom HTTP proxy | ||
| * @param bearerTokenAuthenticator An implementation of {@link BearerTokenAuthenticatorInterface} that provides tokens | ||
| * @param environment The environment to target | ||
| * @param proxy Optional HTTP proxy (can be null for direct connection) | ||
| */ | ||
| public AppStoreServerAPIClient(BearerTokenAuthenticatorInterface bearerTokenAuthenticator, | ||
| Environment environment, | ||
| java.net.Proxy proxy) { | ||
| super(bearerTokenAuthenticator, environment); | ||
| OkHttpClient.Builder builder = new OkHttpClient.Builder(); | ||
| if (proxy != null) { | ||
| builder.proxy(proxy); | ||
| } | ||
| // Use system authenticator for proxy credentials if needed | ||
| builder.proxyAuthenticator(Authenticator.JAVA_NET_AUTHENTICATOR); | ||
| this.httpClient = builder.build(); | ||
| this.urlBase = HttpUrl.parse(this.url); | ||
| } | ||
|
|
||
| /** | ||
| * Create an App Store Server API client with proxy and signing credentials | ||
| * @param signingKey Your private key downloaded from App Store Connect | ||
| * @param keyId Your private key ID from App Store Connect | ||
| * @param issuerId Your issuer ID from the Keys page in App Store Connect | ||
| * @param bundleId Your app’s bundle ID | ||
| * @param environment The environment to target | ||
| * @param proxy Optional HTTP proxy (can be null for direct connection) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we reword this slightly to |
||
| */ | ||
| public AppStoreServerAPIClient(String signingKey, | ||
| String keyId, | ||
| String issuerId, | ||
| String bundleId, | ||
| Environment environment, | ||
| java.net.Proxy proxy) { | ||
| this(new BearerTokenAuthenticator(signingKey, keyId, issuerId, bundleId), environment, proxy); | ||
| } | ||
|
|
||
|
|
||
| @Override | ||
| protected HttpResponseInterface makeRequest(String path, | ||
| String method, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have the existing constructor delegate to these new constructors with a null proxy please? That should reduce code duplication