Variable defaults to null but has been omitted before

[eliias]

This commit has removed a condition that previously made the function return if a variable was optional and not set. From 2.5.0 on, every variable is set to null, if optional and not provided any value. I wonder if the new behaviour is intentional and just right or if this is a regression (could not find anything related in changelog).

Intended outcome:

variables: {}

Actual outcome:

variables: {
  transform: null
}

How to reproduce the issue:

Create a mutation with at least one optional variable. Call the mutation without a value for the optional variable.

Compared versions:

• 2.4.1 (variable is not set)
• 2.5.0, 2.5.1, 2.5.2 (all 2.5.x seems to have the regression)

The GraphQL query has an optional variable transform.

mutation saveX ($transform: Transform) {
  myX(transform: $transform) {
    …
  }
}

Version

• apollo-client@2.5.1
• react-apollo@2.5.1

[hwillson]

@eliias Can you confirm if this is still happening with react-apollo 2.5.3?

[eliias]

@hwillson Can report in the evening. 👋 to a fellow Ottawa citizen :D

[eliias]

Did a quick check on 2.5.3 and tested locally. It still adds {transform: null} to the request payload in case the variable is not set.

[ShepelievD]

Can also confirm in 2.5.3

[AdamTyler]

This issue is preventing me from creating queries with default values. Since omitted variables come in as null it won't replace them with the defaults

[hwillson]

This was fixed in #3056 and will be published in the next RA release. Thanks!

[silentsakky]

@hwillson Any dates for next RA release? it's almost 5 months and fix is not released yet