chore: Fix flaky test_memory_estimation
#1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
Pijukatel
force-pushed
the
fix-flaky-memory-test
branch
from
5757fed to
bf48887
Compare
Pijukatel
changed the title
test_memory_estimation
Pijukatel
changed the title
test_memory_estimationtest_memory_estimation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase the tolerance for the difference between shared and non-shared processes' memory estimation in the test.
Issues
test_memory_estimation...is failing on Linux & Python 3.11 #1288Testing
Stress-tested 300 times in CI without error.