refactor: Unify Actor context manager with init & exit methods #600
+269
−224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To align the behavior between the two possible approaches of using an Actor - as a context manager or by explicitly calling
init
/exit
/fail
- the following changes were implemented:exit_code
,status_message
,event_listeners_timeout
,cleanup_timeout
) were added to theActor.__init__
as well.exit_code
andstatus_message
are now public properties with setters, allowing them to be updated within a context manager block in response to error conditions.__aenter__
frominit
and__aexit__
fromexit
was reversed, ensuring fewer inconsistencies for future changes (since__aenter__
and__aexit__
have a fixed number of arguments).Other changes:
Issues
Testing