Skip to content

fix: fix duplicate logs from apify logger in Scrapy integration #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix: fix duplicate logs from apify logger in Scrapy integration #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/apify/scrapy/_logging_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,8 @@ def _configure_logger(name: str | None, logging_level: str, handler: logging.Han
logger = logging.getLogger(name)
logger.handlers.clear()
logger.setLevel(logging_level)

if name is None: # Root logger.
logger.addHandler(handler)
logger.propagate = False
else:
logger.propagate = True
logger.addHandler(handler)
logger.propagate = False


def initialize_logging() -> None:
Expand Down