Skip to content

fix: add upper bound of HTTPX version #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: add upper bound of HTTPX version #347

merged 1 commit into from
Dec 3, 2024

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Dec 3, 2024 •
edited
Loading

  • HTTPX 0.27 supports both the proxies and proxy args, while version 0.28 supports only the proxy.
  • I am adopting the updated arg name to align with the newer version.
  • However, we cannot fully upgrade to 0.28 as there are more issues.

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Dec 3, 2024
@vdusek vdusek added this to the 104th sprint - Tooling team milestone Dec 3, 2024
@vdusek vdusek requested a review from janbuchar December 3, 2024 08:56
@vdusek vdusek self-assigned this Dec 3, 2024
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Dec 3, 2024
@vdusek vdusek force-pushed the adapt-to-new-version-of-httpx branch from e39624b to 4e21003 Compare December 3, 2024 09:01
@vdusek vdusek changed the title fix: ensure compatibility with HTTPX v0.28 fix: add upper bound of HTTPX version Dec 3, 2024
janbuchar
janbuchar approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! I suppose the same is happening in Crawlee?

@vdusek vdusek merged commit e86dbce into master Dec 3, 2024
29 checks passed
@vdusek vdusek deleted the adapt-to-new-version-of-httpx branch December 3, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbuchar janbuchar janbuchar approved these changes

Assignees

@vdusek vdusek

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
104th sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@vdusek @janbuchar