Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ httpx = ">=0.27.0"
lazy-object-proxy = ">=1.10.0"
scrapy = { version = ">=2.11.0", optional = true }
typing-extensions = ">=4.1.0"
websockets = ">=10.0"
websockets = ">=10.0 <14.0.0"

[tool.poetry.group.dev.dependencies]
build = "~1.2.0"
Expand Down
5 changes: 3 additions & 2 deletions src/apify/apify_storage_client/_dataset_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ async def iterate_items(
skip_empty: bool = False,
skip_hidden: bool = False,
) -> AsyncIterator[dict]:
return self._client.iterate_items(
async for item in self._client.iterate_items(
offset=offset,
limit=limit,
clean=clean,
Expand All @@ -101,7 +101,8 @@ async def iterate_items(
unwind=unwind,
skip_empty=skip_empty,
skip_hidden=skip_hidden,
)
):
yield item

@override
async def get_items_as_bytes(
Expand Down
20 changes: 20 additions & 0 deletions tests/integration/test_actor_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,26 @@ async def main() -> None:
assert item['str'] == 'x' * 10000


async def test_dataset_iter_items(
make_actor: MakeActorFunction,
run_actor: RunActorFunction,
) -> None:
async def main() -> None:
inserted_data = {'Something': 'something else'}

async with Actor:
dataset = await Actor.open_dataset()
await dataset.push_data(inserted_data)
requested_data = [item async for item in dataset.iterate_items()]

assert len(requested_data) == 1
assert requested_data[0] == inserted_data

actor = await make_actor(label='test_dataset_iter_items', main_func=main)
run_result = await run_actor(actor)
assert run_result.status == 'SUCCEEDED'


async def test_same_references_in_default_dataset(
make_actor: MakeActorFunction,
run_actor: RunActorFunction,
Expand Down