This repository was archived by the owner on Nov 8, 2024. It is now read-only.
fix(core): fix structure type attributes #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylef
suggested changes
Sep 22, 2020
kylef
approved these changes
Sep 23, 2020
patricksmms
force-pushed
the
patricksmms/fix-inherited-attrs-in-value-of
branch
from
90e5a86 to
3bd0e39
Compare
kylef
approved these changes
Sep 23, 2020
| * @return {boolean} | ||
| */ | ||
| const isFixed = e => hasTypeAttribute(e, 'fixed') || hasTypeAttribute(e, 'fixedType'); | ||
| const isFixed = e => hasTypeAttribute(e, 'fixed'); |
There was a problem hiding this comment.
Unrelated to PR but just something I noticed while reading this again, would be nice to make hasTypeAttribute curried and in opposite argument order. I can make a PR once these are merged
const isFixed = hasTypeAttribute('fixed');
There was a problem hiding this comment.
I can do that on another PR
patricksmms
added a commit
that referenced
this pull request
Sep 23, 2020
patricksmms
added a commit
that referenced
this pull request
Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to sort out the attributes functionalities.
This was implemented before, but was broken https://github.com/apiaryio/api-elements.js/pull/561/files#diff-ed3f4907fe76fdf2e90227edd1bba42cL70