This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Fix source map locations for OAS 3 warnings #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylef
commented
May 16, 2019
|
|
||
| if (examples.length > 1) { | ||
| parseResult.push(createWarning(namespace, `'${name}' 'examples' only one example is supported, other examples have been ignored`, examples)); | ||
| parseResult.push(createWarning(namespace, `'${name}' 'examples' only one example is supported, other examples have been ignored`, examples.content[1])); |
There was a problem hiding this comment.
"examples" is an array and thus doesn't have source maps, we should point to the 1st example which causes the warning for source maps.
There was a problem hiding this comment.
Isn't this an ideal case for providing multiple source map ranges? 😉 Not that I need them, this solution is fine for Dredd.
kylef
commented
May 16, 2019
| isValidType, | ||
| R.compose( | ||
| createWarning(namespace, `'Schema Object' 'type' must be either ${types.join(', ')}`), | ||
| getValue |
There was a problem hiding this comment.
"type" the element passed ot createWarning is a member element and not a value and thus does not contain source maps.
honzajavorek
approved these changes
May 17, 2019
|
|
||
| if (examples.length > 1) { | ||
| parseResult.push(createWarning(namespace, `'${name}' 'examples' only one example is supported, other examples have been ignored`, examples)); | ||
| parseResult.push(createWarning(namespace, `'${name}' 'examples' only one example is supported, other examples have been ignored`, examples.content[1])); |
There was a problem hiding this comment.
Isn't this an ideal case for providing multiple source map ranges? 😉 Not that I need them, this solution is fine for Dredd.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered missing source maps on two types of warnings, will comment below.