feat(next): use react-query #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
malikalahfaoui
commented
Mar 14, 2022
malikalahfaoui
commented
| Q | A |
|---|---|
| Branch? | main for features / current stable version branch for bug fixes |
| Tickets | #... |
| License | MIT |
| Doc PR | api-platform/docs#... |
alanpoulain
reviewed
Mar 14, 2022
| const delete{{{ucf}}} = async (id) => | ||
| await fetch(id, { method: "DELETE" }); | ||
|
|
||
|
|
There was a problem hiding this comment.
nitpick: Please remove one line.
alanpoulain
reviewed
Mar 14, 2022
Comment on lines
28
to
33
| const save = useMutation(save{{{ucf}}}); | ||
| const deleteMutation = useMutation(()=> delete{{{ucf}}}(book["@id"]), { |
There was a problem hiding this comment.
It's weird to not have consistency for names and mutation function usage.
|
It probably lacks the usage of:
|
|
Why React Query and not SWR... or just nothing? |
|
Let's use react query then 👍 |
malikalahfaoui
force-pushed
the
feat/reactQueryNext
branch
5 times, most recently
from
48354e7 to
0b97ef3
Compare
shaxaaa
reviewed
Mar 21, 2022
| @@ -27,21 +30,22 @@ const Page: NextComponentType<NextPageContext, Props, Props> = (props) => { | |||
| </div> | |||
| <Show {{{lc}}}={ {{{lc}}} } text={ props.text } /> | |||
There was a problem hiding this comment.
There are no props any more and text is not exposed as well from them.
There was a problem hiding this comment.
This issue is corrected on 319
alanpoulain
force-pushed
the
feat/reactQueryNext
branch
2 times, most recently
from
e652731 to
3a7f1ac
Compare
alanpoulain
force-pushed
the
feat/reactQueryNext
branch
4 times, most recently
from
f488445 to
baaf315
Compare
alanpoulain
force-pushed
the
feat/reactQueryNext
branch
from
baaf315 to
ec38894
Compare
alanpoulain
force-pushed
the
feat/reactQueryNext
branch
from
5df9912 to
42f4b2e
Compare
alanpoulain
force-pushed
the
feat/reactQueryNext
branch
from
42f4b2e to
6469fc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.