Use class-string param type for Metadata::getClass #7307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Jul 21, 2025
| @@ -104,11 +105,17 @@ public function withShortName(string $shortName): static | |||
| return $self; | |||
| } | |||
|
|
|||
| /** | |||
| * @return class-string|null | |||
There was a problem hiding this comment.
This is the main change, everything else is changing 'foo' by \stdClass::class in tests to avoid PHPStan failure.
VincentLanglet
force-pushed
the
classString
branch
2 times, most recently
from
66cefee to
92df6bf
Compare
VincentLanglet
force-pushed
the
classString
branch
from
92df6bf to
40a95b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @soyuka
I target main since: