fix(deprecation): alias before autoload if needed #4696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
main
branch
7 times, most recently
from
81e3dc1 to
c5ed986
Compare
azjezz
reviewed
Apr 4, 2022
src/Core/Action/EntrypointAction.php
Outdated
| class_exists(\ApiPlatform\Action\EntrypointAction::class); | ||
|
|
||
| if (false) { | ||
| class EntrypointAction extends \ApiPlatform\Action\EntrypointAction |
Contributor
There was a problem hiding this comment.
as mentioned in the internal discussion, since ApiPlatform\Action\EntrypointAction is final, the deprecated alias ( ApiPlatform\Core\Action\EntrypointAction ) needs to also be declared final so static analysis tools would be able to warn users when they try to extend from it. ( same applies for all other final classes )
Suggested change
| class EntrypointAction extends \ApiPlatform\Action\EntrypointAction | |
| final class EntrypointAction extends \ApiPlatform\Action\EntrypointAction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4694