DTO and ObjectMapper missing @id and @type

[alexandre-castelain]

API Platform version(s) affected: api-platform/state:4.2.10

Description
Using DTO and ObjectMapper, the @type and @id are not properly set.

How to reproduce

• Clone : https://github.com/mtarld/sfcon-apip/tree/main
• Install the project
• Composer update
• Fetch the list of books

Possible Solution
The problem comes with this commit.

As you can see in the screenshots below, the commit fixes another problem where the DTO was not used for deserialization.

Additional Context

Before 4.2.10 :

After 4.2.10 :

[soyuka]

Indeed but I think that it was wrong previously or we need to change how output are considered globally. Let's say you use an output that has absolutely nothing in common then it'll be quite wrong as dereferencing the item will not be correct anymore.

The best for this is to put the GetCollection on the dto you're using for the collection.

[alexandre-castelain]

During SymfonyCon, Mathias Arlaud said in his talk that he recommends using DTOs instead of serialization groups.
If it ends up that the data returned isn’t the same between the two, is it really a best practice?

I’m not trying to be right at all costs — I’m trying to understand which approach is recommended.
Using DTOs is nice, but with this change, I feel like it loses a bit of its smoothness.

[Spomky]

Hi,

Indeed, I noticed this behavior a few days ago.
To my understanding:
* The @id should be preserved. Whatever is returned, the resource identifier must not change.
* The @type should reflect the actual object type. Therefore, when a DTO is returned, it should not expose the same type as the resource itself.

Unless I am mistaken, I am currently working on a PR to address this.

[Spomky]

Actually there is nothing to do and @soyuka advice's is the way to go.
The repository created by @mtarld should be updated as follows
Just move the GetCollection operation from the Book resource to the BookCollection Dto. It will work fine.

[alexandre-castelain]

Thanks for the PR @Spomky ! It helped me fixing my code :)