Added support for multiple header value in API Gateway #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ahah silly AWS APIs..., looks good to me though, mind adding a test? I suppose we could probably always just set the multiple headers one? Since Go gives you a slice anyway |
|
@mattdelaf You have to implement on the Request side as well. https://github.com/apex/gateway/blob/master/request.go#L51 |
This was referenced May 20, 2019
|
How do you use this library |
|
@davidfaynzilberg check out the readme, there's an example. It's basically a drop-in replacement for net/http for Lambda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last October AWS announced support for multi-value headers.
Since version 1.8.1,
aws-lambda-gopackage events supports multi-value headers asmap[string][]string.This is particularly useful for setting multiple cookies. This is a quick fix proposal.