-
Notifications
You must be signed in to change notification settings - Fork 29k
Update Java api for setJobGroup with interruptOnCancel #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff here is really dumb, I just put the sem.acquire(2) above the creation of jobB in this test ("job group") and then copied it to make my test ("job group with interruption"). The latter test is only different in that I sleep for an extraordinarily long amount of time, so that cancellation must interrupt the sleep or else make Patrick angry.
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
lgtm |
|
Merged. |
Also adds a unit test. Author: Aaron Davidson <[email protected]> Closes #522 from aarondav/cancel2 and squashes the following commits: 565c253 [Aaron Davidson] Update Java api for setJobGroup with interruptOnCancel 65b33d8 [Aaron Davidson] Add unit test for Thread interruption on cancellation (cherry picked from commit d485eec) Signed-off-by: Reynold Xin <[email protected]>
Also adds a unit test. Author: Aaron Davidson <[email protected]> Closes apache#522 from aarondav/cancel2 and squashes the following commits: 565c253 [Aaron Davidson] Update Java api for setJobGroup with interruptOnCancel 65b33d8 [Aaron Davidson] Add unit test for Thread interruption on cancellation
apache#522 got messed after i rewrote the branch hadoop_jar_name. So created a new one. Author: Bijay Bisht <[email protected]> Closes apache#584 from bijaybisht/hadoop_jar_name_on_0.9.0 and squashes the following commits: 1b6fb3c [Bijay Bisht] Ported hadoopClient jar for < 1.0.1 fix
…ic allocation mode (rebased) (#522) * Use emptyDir volume mounts for executor local directories. * Mount local dirs in the driver. Remove shuffle dir configuration. * Arrange imports * Fix style and integration tests. * Add TODO note for volume types to change. * Add unit test and extra documentation. * Fix existing unit tests and add tests for empty dir volumes * Remove extraneous constant (cherry picked from commit 49932d6) Conflicts: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
…ic allocation mode (rebased) (apache#522) * Use emptyDir volume mounts for executor local directories. * Mount local dirs in the driver. Remove shuffle dir configuration. * Arrange imports * Fix style and integration tests. * Add TODO note for volume types to change. * Add unit test and extra documentation. * Fix existing unit tests and add tests for empty dir volumes * Remove extraneous constant
* Change the volcano docker image and fix some nit - Change the docker image to make volcano record job start time and end time - Change the timeout of job because it now do not need that long time * make the kubeflow and volcano version configurable
Also adds a unit test.