Skip to content

Conversation

@aarondav
Copy link
Contributor

Also adds a unit test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff here is really dumb, I just put the sem.acquire(2) above the creation of jobB in this test ("job group") and then copied it to make my test ("job group with interruption"). The latter test is only different in that I sleep for an extraordinarily long amount of time, so that cancellation must interrupt the sleep or else make Patrick angry.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14420/

@rxin
Copy link
Contributor

rxin commented Apr 24, 2014

lgtm

@rxin
Copy link
Contributor

rxin commented Apr 24, 2014

Merged.

asfgit pushed a commit that referenced this pull request Apr 24, 2014
Also adds a unit test.

Author: Aaron Davidson <[email protected]>

Closes #522 from aarondav/cancel2 and squashes the following commits:

565c253 [Aaron Davidson] Update Java api for setJobGroup with interruptOnCancel
65b33d8 [Aaron Davidson] Add unit test for Thread interruption on cancellation

(cherry picked from commit d485eec)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in d485eec Apr 24, 2014
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
Also adds a unit test.

Author: Aaron Davidson <[email protected]>

Closes apache#522 from aarondav/cancel2 and squashes the following commits:

565c253 [Aaron Davidson] Update Java api for setJobGroup with interruptOnCancel
65b33d8 [Aaron Davidson] Add unit test for Thread interruption on cancellation
andrewor14 pushed a commit to andrewor14/spark that referenced this pull request Jan 8, 2015
apache#522 got messed after i rewrote the branch hadoop_jar_name. So created a new one.

Author: Bijay Bisht <[email protected]>

Closes apache#584 from bijaybisht/hadoop_jar_name_on_0.9.0 and squashes the following commits:

1b6fb3c [Bijay Bisht] Ported hadoopClient jar for < 1.0.1 fix
ash211 referenced this pull request in palantir/spark Oct 16, 2017
…ic allocation mode (rebased) (#522)

* Use emptyDir volume mounts for executor local directories.

* Mount local dirs in the driver. Remove shuffle dir configuration.

* Arrange imports

* Fix style and integration tests.

* Add TODO note for volume types to change.

* Add unit test and extra documentation.

* Fix existing unit tests and add tests for empty dir volumes

* Remove extraneous constant

(cherry picked from commit 49932d6)

 Conflicts:
	resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
markhamstra pushed a commit to markhamstra/spark that referenced this pull request Nov 7, 2017
…ic allocation mode (rebased) (apache#522)

* Use emptyDir volume mounts for executor local directories.

* Mount local dirs in the driver. Remove shuffle dir configuration.

* Arrange imports

* Fix style and integration tests.

* Add TODO note for volume types to change.

* Add unit test and extra documentation.

* Fix existing unit tests and add tests for empty dir volumes

* Remove extraneous constant
bzhaoopenstack pushed a commit to bzhaoopenstack/spark that referenced this pull request Sep 11, 2019
* Change the volcano docker image and fix some nit

- Change the docker image to make volcano record job start time and end
  time
- Change the timeout of job because it now do not need that long time

* make the kubeflow and volcano version configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants