Skip to content

Conversation

@nchammas
Copy link
Contributor

What changes were proposed in this pull request?

Remove standalone SQL error pages that were made obsolete by the work completed in #44971.

Also fix the formatting of the error message for QUERY_ONLY_CORRUPT_RECORD_COLUMN, since it was incorrect and overflowing the table cell it belongs to.

Why are the changes needed?

These error pages are either already captured completely in common/utils/src/main/resources/error/error-conditions.json, or are obsolete and not needed (and are not being rendered in the documentation output anyway).

The formatting of QUERY_ONLY_CORRUPT_RECORD_COLUMN before and after:

Does this PR introduce any user-facing change?

Yes, documentation formatting.

How was this patch tested?

Built the docs locally and reviewed them in my browser.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the DOCS label Jan 14, 2025
@nchammas
Copy link
Contributor Author

cc @MaxGekk as I believe you have recently reviewed similar doc PRs.

@MaxGekk
Copy link
Member

MaxGekk commented Jan 15, 2025

+1, LGTM. Merging to master.
Thank you, @nchammas.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@MaxGekk MaxGekk closed this in 21a37a7 Jan 15, 2025
@nchammas nchammas deleted the SPARK-50814-unused-error-docs branch January 15, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants