Skip to content

Conversation

@milanisvet
Copy link
Contributor

@milanisvet milanisvet commented Dec 13, 2024

What changes were proposed in this pull request?

PR adds new parameters to already existing classes UnresolvedWith, CTERelationRef and CTERelationDef to enable later implementation of recursive CTEs.

Why are the changes needed?

Support for the recursive CTE.

Does this PR introduce any user-facing change?

No. RECURSIVE keyword is not introduced in this PR.

How was this patch tested?

The tests failing after the initial change were all in SQLQueryTestSuite, so this patch was tested by running this Test Suite.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Dec 13, 2024
@MaxGekk
Copy link
Member

MaxGekk commented Dec 13, 2024

@peter-toth Please, have a look at the PR.

@milanisvet
Copy link
Contributor Author

@peter-toth Please, have a look at the PR.

We already contacted Peter and I don't think he will have time to review it. Could you have a look at it? This PR are only small no-op changes to enable later introduction to recursive CTEs.

@peter-toth
Copy link
Contributor

I've just taken a quick look, and this PR seems to just extract some changes from my #40744 so I'm fine with these changes.

But @milanisvet , if you want to split the changes into smaller pieces then probably SPARK-24497 should be converted to an umbrella/epic ticket and the changes should be subtasks of it.

@cloud-fan, @dongjoon-hyun what is the preffered way of organizing the work?

@milanisvet
Copy link
Contributor Author

@peter-toth thanks a lot for your comment. Let us then wait for @cloud-fan to answer the question about JIRA, so that I know if I should restructure it. After that, hopefully we can merge this.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan
Copy link
Contributor

Oh, I'll merge after the proper JIRA ticket is created.

@milanisvet milanisvet changed the title [SPARK-24497][SQL] An initial, no-op PR which adds new parameters to already existing classes UnresolvedWith, CTERelationRef and CTERelationDef to enable later implementation of recursive CTEs. [SPARK-50598][SQL] An initial, no-op PR which adds new parameters to already existing classes UnresolvedWith, CTERelationRef and CTERelationDef to enable later implementation of recursive CTEs. Dec 17, 2024
@milanisvet
Copy link
Contributor Author

JIRA subticket created, and the PR description is changed with the new JIRA ticket number @cloud-fan
Thanks again for approving :)

@cloud-fan cloud-fan closed this in accde83 Dec 17, 2024
@milanisvet milanisvet deleted the milanrcte2 branch January 6, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants