-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-50598][SQL] An initial, no-op PR which adds new parameters to already existing classes UnresolvedWith, CTERelationRef and CTERelationDef to enable later implementation of recursive CTEs. #49180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ationRef and CTERelationDef
|
@peter-toth Please, have a look at the PR. |
… recursion tests later" This reverts commit 5f4859b.
We already contacted Peter and I don't think he will have time to review it. Could you have a look at it? This PR are only small no-op changes to enable later introduction to recursive CTEs. |
|
I've just taken a quick look, and this PR seems to just extract some changes from my #40744 so I'm fine with these changes. But @milanisvet , if you want to split the changes into smaller pieces then probably SPARK-24497 should be converted to an umbrella/epic ticket and the changes should be subtasks of it. @cloud-fan, @dongjoon-hyun what is the preffered way of organizing the work? |
|
@peter-toth thanks a lot for your comment. Let us then wait for @cloud-fan to answer the question about JIRA, so that I know if I should restructure it. After that, hopefully we can merge this. |
...alyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
Outdated
Show resolved
Hide resolved
...alyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
Outdated
Show resolved
Hide resolved
|
thanks, merging to master! |
|
Oh, I'll merge after the proper JIRA ticket is created. |
|
JIRA subticket created, and the PR description is changed with the new JIRA ticket number @cloud-fan |
What changes were proposed in this pull request?
PR adds new parameters to already existing classes UnresolvedWith, CTERelationRef and CTERelationDef to enable later implementation of recursive CTEs.
Why are the changes needed?
Support for the recursive CTE.
Does this PR introduce any user-facing change?
No. RECURSIVE keyword is not introduced in this PR.
How was this patch tested?
The tests failing after the initial change were all in
SQLQueryTestSuite, so this patch was tested by running this Test Suite.Was this patch authored or co-authored using generative AI tooling?
No.