[SPARK-48066][SQL][TESTS] Enable ANSI for TPCDSQueryBenchmark #47787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Aug 16, 2024
yaooqinn
commented
Aug 16, 2024
| TPCDS: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative | ||
| ------------------------------------------------------------------------------------------------------------------------ | ||
| q50 555 599 48 5.8 171.3 1.0X | ||
| q50 784 841 51 4.1 241.8 1.0X |
yaooqinn
commented
Aug 16, 2024
| TPCDS: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative | ||
| ------------------------------------------------------------------------------------------------------------------------ | ||
| q49 542 629 63 10.4 96.6 1.0X | ||
| q49 670 761 131 8.4 119.3 1.0X |
yaooqinn
commented
Aug 16, 2024
| TPCDS: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative | ||
| ------------------------------------------------------------------------------------------------------------------------ | ||
| q58 414 442 27 12.4 80.8 1.0X | ||
| q58 412 543 195 12.4 80.4 1.0X |
yaooqinn
commented
Aug 16, 2024
| TPCDS: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative | ||
| ------------------------------------------------------------------------------------------------------------------------ | ||
| q72 114724 116824 2969 0.1 7474.9 1.0X | ||
| q72 136543 138257 2425 0.1 8896.5 1.0X |
yaooqinn
commented
Aug 16, 2024
| TPCDS: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative | ||
| ------------------------------------------------------------------------------------------------------------------------ | ||
| q80 943 1188 346 6.0 167.0 1.0X | ||
| q80 1318 1555 335 4.3 233.5 1.0X |
yaooqinn
commented
Aug 16, 2024
| AMD EPYC 7763 64-Core Processor | ||
| TPCDS: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative | ||
| ------------------------------------------------------------------------------------------------------------------------ | ||
| q72-v2.7 114303 116853 3606 0.1 7447.5 1.0X |
yaooqinn
commented
Aug 16, 2024
| AMD EPYC 7763 64-Core Processor | ||
| TPCDS: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative | ||
| ------------------------------------------------------------------------------------------------------------------------ | ||
| q77a-v2.7 646 755 153 8.7 115.1 1.0X |
yaooqinn
changed the title
Member
Author
|
Also cc @dongjoon-hyun from #47743 |
ulysses-you
approved these changes
Aug 16, 2024
dongjoon-hyun
approved these changes
Aug 16, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for the rechecking and update, @yaooqinn .
Ya, I'm also not sure what was the root cause at that time. In any way, it's a great to have this update.
For the perf difference part, we can track from now properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TPCDSQueryBenchmark still runs on ANSI OFF mode because of
I have tested it with the latest revision on my local machine, and somehow the issue seems to have been resolved. And so do the GA results
Why are the changes needed?
improve test coverage for ANSI default
Does this PR introduce any user-facing change?
no
How was this patch tested?
benchmarking
Was this patch authored or co-authored using generative AI tooling?
no