Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jul 25, 2024

What changes were proposed in this pull request?

This PR aims to use 17-jammy tag instead of 17 to prevent Python 12.

Why are the changes needed?

Two days ago, eclipse-temurin:17 switched its baseline OS to Ubuntu 24.04 which brings Python 3.12.

$ docker run -it --rm eclipse-temurin:17 cat /etc/os-release | grep VERSION_ID
VERSION_ID="24.04"

$ docker run -it --rm eclipse-temurin:17-jammy cat /etc/os-release | grep VERSION_ID
VERSION_ID="22.04"

Since Python 3.12 supported is added only to Apache Spark 4.0.0, we need to keep using the previous OS, Ubuntu 22.04.

Does this PR introduce any user-facing change?

No. This aims to recover to the same OS for consistent behavior.

How was this patch tested?

Pass the CIs with K8s IT. Currently, it's broken at Python image building phase.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-49005][K8S][3.5] Use 17-jammy tag instead of 17 to prevent Pyth… [SPARK-49005][K8S][3.5] Use 17-jammy tag instead of 17 to prevent Python Jul 25, 2024
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-49005][K8S][3.5] Use 17-jammy tag instead of 17 to prevent Python [SPARK-49005][K8S][3.5] Use 17-jammy tag instead of 17 to prevent Python 12 Jul 25, 2024
@dongjoon-hyun
Copy link
Member Author

cc @yaooqinn and @viirya

@dongjoon-hyun
Copy link
Member Author

Also, cc @huaxingao

Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR @dongjoon-hyun

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @huaxingao !

@dongjoon-hyun
Copy link
Member Author

Let me merge this to recover the CIs.

dongjoon-hyun added a commit that referenced this pull request Jul 25, 2024
… Python 12

### What changes were proposed in this pull request?

This PR aims to use `17-jammy` tag instead of `17` to prevent Python 12.

### Why are the changes needed?

Two days ago, `eclipse-temurin:17` switched its baseline OS to `Ubuntu 24.04` which brings `Python 3.12`.

```
$ docker run -it --rm eclipse-temurin:17 cat /etc/os-release | grep VERSION_ID
VERSION_ID="24.04"

$ docker run -it --rm eclipse-temurin:17-jammy cat /etc/os-release | grep VERSION_ID
VERSION_ID="22.04"
```

Since Python 3.12 supported is added only to Apache Spark 4.0.0, we need to keep using the previous OS, `Ubuntu 22.04`.

- #43184
- #43192

### Does this PR introduce _any_ user-facing change?

No. This aims to recover to the same OS for consistent behavior.

### How was this patch tested?

Pass the CIs with K8s IT. Currently, it's broken at Python image building phase.

- https://github.com/apache/spark/actions/workflows/build_branch35.yml

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #47488 from dongjoon-hyun/SPARK-49005.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun dongjoon-hyun deleted the SPARK-49005 branch July 25, 2024 17:42
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya !

@yaooqinn
Copy link
Member

Late LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @yaooqinn .

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-49005][K8S][3.5] Use 17-jammy tag instead of 17 to prevent Python 12 [SPARK-49005][K8S][3.5] Use 17-jammy tag instead of 17 to prevent Python 3.12 Jul 26, 2024
peter-toth added a commit to apache/spark-docker that referenced this pull request Oct 7, 2025
…ammy

### What changes were proposed in this pull request?

This PR proposes to switch future Apache Spark 3.5 Java 11 docket images to `11-jammy`.
We have applied a similar change to Apache Spark repo Java 17 dockerfile in [SPARK-49005](https://issues.apache.org/jira/browse/SPARK-49005) / apache/spark#47488.

### Why are the changes needed?

The current `11-jre-focal` is no longer supported by Docker Library: docker-library/official-images#19948 (comment)

### Does this PR introduce _any_ user-facing change?

No, we will not republish the 3.5.7 Apache Docker Hub image.

### How was this patch tested?

Manual review.

Closes #95 from peter-toth/SPARK-53730-switch-spark-3.5-to-11-jammy.

Authored-by: Peter Toth <[email protected]>
Signed-off-by: Peter Toth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants