-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-49005][K8S][3.5] Use 17-jammy tag instead of 17 to prevent Python 3.12
#47488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
17-jammy tag instead of 17 to prevent Pyth…17-jammy tag instead of 17 to prevent Python
17-jammy tag instead of 17 to prevent Python17-jammy tag instead of 17 to prevent Python 12
|
Also, cc @huaxingao |
huaxingao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR @dongjoon-hyun
|
Thank you so much, @huaxingao ! |
|
Let me merge this to recover the CIs. |
… Python 12 ### What changes were proposed in this pull request? This PR aims to use `17-jammy` tag instead of `17` to prevent Python 12. ### Why are the changes needed? Two days ago, `eclipse-temurin:17` switched its baseline OS to `Ubuntu 24.04` which brings `Python 3.12`. ``` $ docker run -it --rm eclipse-temurin:17 cat /etc/os-release | grep VERSION_ID VERSION_ID="24.04" $ docker run -it --rm eclipse-temurin:17-jammy cat /etc/os-release | grep VERSION_ID VERSION_ID="22.04" ``` Since Python 3.12 supported is added only to Apache Spark 4.0.0, we need to keep using the previous OS, `Ubuntu 22.04`. - #43184 - #43192 ### Does this PR introduce _any_ user-facing change? No. This aims to recover to the same OS for consistent behavior. ### How was this patch tested? Pass the CIs with K8s IT. Currently, it's broken at Python image building phase. - https://github.com/apache/spark/actions/workflows/build_branch35.yml ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47488 from dongjoon-hyun/SPARK-49005. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
viirya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
Thank you, @viirya ! |
|
Late LGTM |
|
Thank you, @yaooqinn . |
17-jammy tag instead of 17 to prevent Python 1217-jammy tag instead of 17 to prevent Python 3.12
…ammy ### What changes were proposed in this pull request? This PR proposes to switch future Apache Spark 3.5 Java 11 docket images to `11-jammy`. We have applied a similar change to Apache Spark repo Java 17 dockerfile in [SPARK-49005](https://issues.apache.org/jira/browse/SPARK-49005) / apache/spark#47488. ### Why are the changes needed? The current `11-jre-focal` is no longer supported by Docker Library: docker-library/official-images#19948 (comment) ### Does this PR introduce _any_ user-facing change? No, we will not republish the 3.5.7 Apache Docker Hub image. ### How was this patch tested? Manual review. Closes #95 from peter-toth/SPARK-53730-switch-spark-3.5-to-11-jammy. Authored-by: Peter Toth <[email protected]> Signed-off-by: Peter Toth <[email protected]>
What changes were proposed in this pull request?
This PR aims to use
17-jammytag instead of17to prevent Python 12.Why are the changes needed?
Two days ago,
eclipse-temurin:17switched its baseline OS toUbuntu 24.04which bringsPython 3.12.Since Python 3.12 supported is added only to Apache Spark 4.0.0, we need to keep using the previous OS,
Ubuntu 22.04.distutilsusage #43192Does this PR introduce any user-facing change?
No. This aims to recover to the same OS for consistent behavior.
How was this patch tested?
Pass the CIs with K8s IT. Currently, it's broken at Python image building phase.
Was this patch authored or co-authored using generative AI tooling?
No.