Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Apr 24, 2024

What changes were proposed in this pull request?

This PR aims to switch spark.sql.legacy.createHiveTableByDefault to false by default in order to move away from this legacy behavior from Apache Spark 4.0.0 while the legacy functionality will be preserved during Apache Spark 4.x period by setting spark.sql.legacy.createHiveTableByDefault=true.

Why are the changes needed?

Historically, this behavior change was merged at Apache Spark 3.0.0 activity in SPARK-30098 and reverted officially during the 3.0.0 RC period.

At Apache Spark 3.1.0, we had another discussion and defined it as Legacy behavior via a new configuration by reusing the JIRA ID, SPARK-30098.

Last year, this was proposed again twice and Apache Spark 4.0.0 is a good time to make a decision for Apache Spark future direction.

  • SPARK-42603 on 2023-02-27 as an independent idea.
  • SPARK-46122 on 2023-11-27 as a part of Apache Spark 4.0.0 idea

Does this PR introduce any user-facing change?

Yes, the migration document is updated.

How was this patch tested?

Pass the CIs with the adjusted test cases.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun marked this pull request as draft April 24, 2024 16:59
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-46122][SQL] Disable spark.sql.legacy.createHiveTableByDefault by default [SPARK-46122][SQL] Disable spark.sql.legacy.createHiveTableByDefault by default Apr 24, 2024
@github-actions github-actions bot added the SQL label Apr 24, 2024
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-46122][SQL] Disable spark.sql.legacy.createHiveTableByDefault by default [SPARK-46122][SQL] Set spark.sql.legacy.createHiveTableByDefault to false by default Apr 24, 2024
@github-actions github-actions bot added the DOCS label Apr 24, 2024
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review April 25, 2024 01:59
Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @yaooqinn . I'll throw a discussion thread for this Tonight.

@dongjoon-hyun
Copy link
Member Author

I started a vote for this PR too.

@dongjoon-hyun
Copy link
Member Author

Hi, @cloud-fan , @yaooqinn , @ulysses-you . If you don't mind, could you participate the vote? :)

@dongjoon-hyun
Copy link
Member Author

Thank you all. Votes passed.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-46122 branch April 30, 2024 08:44
@dongjoon-hyun
Copy link
Member Author

Merged to master for Apache Spark 4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants