[SPARK-45909][SQL] Remove NumericType cast if it can safely up-cast in IsNotNull
#43785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Nov 13, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @wangyum .
dongjoon-hyun
changed the title
IsNotNullNumericType cast if it can safely up-cast in IsNotNull
Member
|
I revisied the title. Please let me know if it's wrong. |
Member
|
Merged to master for Apache Spark 4.0.0. |
Member
Author
|
Thank you @dongjoon-hyun The new PR title looks better than the previous one. |
Member
|
Thank you! |
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
… in `IsNotNull` (apache#253) ### What changes were proposed in this pull request? Similar to SPARK-37922. We can remove the cast if it can safely up-cast in `IsNotNull`. ### Why are the changes needed? Improve the query performance. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#43785 from wangyum/SPARK-45909. Authored-by: Yuming Wang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit a6b089f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Similar to SPARK-37922. We can remove the cast if it can safely up-cast in
IsNotNull.Why are the changes needed?
Improve the query performance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.
Was this patch authored or co-authored using generative AI tooling?
No.