[SPARK-45804][UI] Add spark.ui.threadDump.flamegraphEnabled config to switch flame graph on/off #43674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… switch flame graph on/off
Member
Author
|
cc @cloud-fan from #42988 (comment) |
HyukjinKwon
reviewed
Nov 6, 2023
| .createWithDefault(true) | ||
|
|
||
| val UI_FLAMEGRAPH_ENABLED = ConfigBuilder("spark.ui.threadDump.flamegraphEnabled") | ||
| .doc("Whether to render the Flamegraph for executor thread dumps") |
Member
There was a problem hiding this comment.
I think we should describe this happens within UI ;-)?
Member
Author
There was a problem hiding this comment.
Do you mean that we should add a short paragraph to describe the flame graph gone because users turned it off? I considered this, but it seems that we don't do such things for other UI elements or switches, i.e., timeline, heapdump.
HyukjinKwon
approved these changes
Nov 6, 2023
dongjoon-hyun
approved these changes
Nov 6, 2023
Member
|
Merged to master. |
Member
Author
|
Thank you, as always, @dongjoon-hyun and @HyukjinKwon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add spark.ui.threadDump.flamegraphEnabled config to switch flame graph on/off
Why are the changes needed?
UI stability
Does this PR introduce any user-facing change?
yes, new spark.ui.threadDump.flamegraphEnabled config
How was this patch tested?
locally tested
bin/spark-shell -c spark.ui.threadDump.flamegraphEnabled=true
bin/spark-shell -c spark.ui.threadDump.flamegraphEnabled=false
Was this patch authored or co-authored using generative AI tooling?
no