Skip to content

[SPARK-45157][SQL] Avoid repeated if checks in [On|Off|HeapColumnVector #42903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-45157][SQL] Avoid repeated if checks in [On|Off|HeapColumnVector #42903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ public byte[] getBytes(int rowId, int count) {
Platform.copyMemory(null, data + rowId, array, Platform.BYTE_ARRAY_OFFSET, count);
} else {
for (int i = 0; i < count; i++) {
array[i] = getByte(rowId + i);
array[i] = (byte) dictionary.decodeToInt(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down Expand Up @@ -279,7 +279,7 @@ public short[] getShorts(int rowId, int count) {
Platform.copyMemory(null, data + rowId * 2L, array, Platform.SHORT_ARRAY_OFFSET, count * 2L);
} else {
for (int i = 0; i < count; i++) {
array[i] = getShort(rowId + i);
array[i] = (short) dictionary.decodeToInt(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down Expand Up @@ -345,7 +345,7 @@ public int[] getInts(int rowId, int count) {
Platform.copyMemory(null, data + rowId * 4L, array, Platform.INT_ARRAY_OFFSET, count * 4L);
} else {
for (int i = 0; i < count; i++) {
array[i] = getInt(rowId + i);
array[i] = dictionary.decodeToInt(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down Expand Up @@ -423,7 +423,7 @@ public long[] getLongs(int rowId, int count) {
Platform.copyMemory(null, data + rowId * 8L, array, Platform.LONG_ARRAY_OFFSET, count * 8L);
} else {
for (int i = 0; i < count; i++) {
array[i] = getLong(rowId + i);
array[i] = dictionary.decodeToLong(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down Expand Up @@ -487,7 +487,7 @@ public float[] getFloats(int rowId, int count) {
Platform.copyMemory(null, data + rowId * 4L, array, Platform.FLOAT_ARRAY_OFFSET, count * 4L);
} else {
for (int i = 0; i < count; i++) {
array[i] = getFloat(rowId + i);
array[i] = dictionary.decodeToFloat(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down Expand Up @@ -553,7 +553,7 @@ public double[] getDoubles(int rowId, int count) {
count * 8L);
} else {
for (int i = 0; i < count; i++) {
array[i] = getDouble(rowId + i);
array[i] = dictionary.decodeToDouble(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down
12 changes: 6 additions & 6 deletions sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OnHeapColumnVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ public byte[] getBytes(int rowId, int count) {
System.arraycopy(byteData, rowId, array, 0, count);
} else {
for (int i = 0; i < count; i++) {
array[i] = getByte(rowId + i);
array[i] = (byte) dictionary.decodeToInt(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down Expand Up @@ -276,7 +276,7 @@ public short[] getShorts(int rowId, int count) {
System.arraycopy(shortData, rowId, array, 0, count);
} else {
for (int i = 0; i < count; i++) {
array[i] = getShort(rowId + i);
array[i] = (short) dictionary.decodeToInt(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down Expand Up @@ -337,7 +337,7 @@ public int[] getInts(int rowId, int count) {
System.arraycopy(intData, rowId, array, 0, count);
} else {
for (int i = 0; i < count; i++) {
array[i] = getInt(rowId + i);
array[i] = dictionary.decodeToInt(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down Expand Up @@ -409,7 +409,7 @@ public long[] getLongs(int rowId, int count) {
System.arraycopy(longData, rowId, array, 0, count);
} else {
for (int i = 0; i < count; i++) {
array[i] = getLong(rowId + i);
array[i] = dictionary.decodeToLong(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down Expand Up @@ -466,7 +466,7 @@ public float[] getFloats(int rowId, int count) {
System.arraycopy(floatData, rowId, array, 0, count);
} else {
for (int i = 0; i < count; i++) {
array[i] = getFloat(rowId + i);
array[i] = dictionary.decodeToFloat(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down Expand Up @@ -525,7 +525,7 @@ public double[] getDoubles(int rowId, int count) {
System.arraycopy(doubleData, rowId, array, 0, count);
} else {
for (int i = 0; i < count; i++) {
array[i] = getDouble(rowId + i);
array[i] = dictionary.decodeToDouble(dictionaryIds.getDictId(rowId + i));
}
}
return array;
Expand Down