[SPARK-5324][SQL] Results of describe can't be queried #4249

OopsOutOfMemory · 2015-01-28T12:08:53Z

Make below code works.

sql("DESCRIBE test").registerTempTable("describeTest")
sql("SELECT * FROM describeTest").collect()

OopsOutOfMemory · 2015-01-28T12:10:09Z

/cc @marmbrus

AmplabJenkins · 2015-01-28T12:12:09Z

Can one of the admins verify this patch?

squito · 2015-01-28T15:51:18Z

sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala

nit: I'd prefer that the test name said what the correct behavior is, rather than the old bug it is checking for. I think its better when we're looking at test output, or if there is a regression on this and a dev needs to figure out what is being tests.

Maybe I am wrong about this, though -- we haven't applied that universally so far

that's a great idea

marmbrus · 2015-01-29T23:33:04Z

sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala

Use checkAnswer for test that check the results of queries.

marmbrus · 2015-02-02T02:53:06Z

ok to test

SparkQA · 2015-02-02T02:57:46Z

Test build #26485 has started for PR 4249 at commit 11559ae.

This patch merges cleanly.

SparkQA · 2015-02-02T04:07:14Z

Test build #26485 has finished for PR 4249 at commit 11559ae.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-02T04:07:17Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26485/
Test PASSed.

…sc_query

SparkQA · 2015-02-02T16:12:53Z

Test build #26518 has started for PR 4249 at commit d541a35.

This patch merges cleanly.

SparkQA · 2015-02-02T16:17:49Z

Test build #26519 has started for PR 4249 at commit 354ad71.

This patch merges cleanly.

SparkQA · 2015-02-02T17:21:56Z

Test build #26518 has finished for PR 4249 at commit d541a35.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-02T17:21:59Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26518/
Test PASSed.

SparkQA · 2015-02-02T17:26:16Z

Test build #26519 has finished for PR 4249 at commit 354ad71.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-02T17:26:19Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26519/
Test PASSed.

…sc_query

SparkQA · 2015-02-04T15:27:54Z

Test build #26754 has started for PR 4249 at commit 3ba1058.

This patch merges cleanly.

OopsOutOfMemory · 2015-02-04T15:33:06Z

/cc @marmbrus
make the references as default argument.

SparkQA · 2015-02-04T16:38:31Z

Test build #26754 has finished for PR 4249 at commit 3ba1058.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-04T16:38:34Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26754/
Test PASSed.

liancheng · 2015-02-04T22:26:08Z

sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala

I think it's OK to just change the def to a val without moving output into constructor argument list, so that we don't have to use named parameter isExtended = ... elsewhere. Did I miss something here?

Hmm, i guess that is okay for leaf nodes since they will never be copied...

style fix

SparkQA · 2015-02-05T07:38:01Z

Test build #26831 has started for PR 4249 at commit e71430a.

This patch merges cleanly.

SparkQA · 2015-02-05T08:50:48Z

Test build #26831 has finished for PR 4249 at commit e71430a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-05T08:50:51Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26831/
Test PASSed.

OopsOutOfMemory · 2015-02-05T15:27:46Z

@marmbrus is this ready to go ?

SparkQA · 2015-02-06T07:17:36Z

Test build #26905 has started for PR 4249 at commit 6fee13d.

This patch merges cleanly.

SparkQA · 2015-02-06T08:30:11Z

Test build #26905 has finished for PR 4249 at commit 6fee13d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-06T08:30:14Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26905/
Test PASSed.

Make below code works. ``` sql("DESCRIBE test").registerTempTable("describeTest") sql("SELECT * FROM describeTest").collect() ``` Author: OopsOutOfMemory <[email protected]> Author: Sheng, Li <[email protected]> Closes #4249 from OopsOutOfMemory/desc_query and squashes the following commits: 6fee13d [OopsOutOfMemory] up-to-date e71430a [Sheng, Li] Update HiveOperatorQueryableSuite.scala 3ba1058 [OopsOutOfMemory] change to default argument aac7226 [OopsOutOfMemory] Merge branch 'master' into desc_query 68eb6dd [OopsOutOfMemory] Merge branch 'desc_query' of github.com:OopsOutOfMemory/spark into desc_query 354ad71 [OopsOutOfMemory] query describe command d541a35 [OopsOutOfMemory] refine test suite e1da481 [OopsOutOfMemory] refine test suite a780539 [OopsOutOfMemory] Merge branch 'desc_query' of github.com:OopsOutOfMemory/spark into desc_query 0015f82 [OopsOutOfMemory] code style dd0aaef [OopsOutOfMemory] code style c7d606d [OopsOutOfMemory] rename test suite 75f2342 [OopsOutOfMemory] refine code and test suite f942c9b [OopsOutOfMemory] initial 11559ae [OopsOutOfMemory] code style c5fdecf [OopsOutOfMemory] code style aeaea5f [OopsOutOfMemory] rename test suite ac2c3bb [OopsOutOfMemory] refine code and test suite 544573e [OopsOutOfMemory] initial (cherry picked from commit 0b7eb3f) Signed-off-by: Michael Armbrust <[email protected]>

marmbrus · 2015-02-06T20:35:16Z

Thanks! Merged to master and 1.3

OopsOutOfMemory added 2 commits January 28, 2015 18:48

initial

544573e

refine code and test suite

ac2c3bb

squito reviewed Jan 28, 2015
View reviewed changes

OopsOutOfMemory added 3 commits January 29, 2015 08:53

rename test suite

aeaea5f

code style

c5fdecf

code style

11559ae

marmbrus reviewed Jan 29, 2015
View reviewed changes

OopsOutOfMemory added 8 commits February 2, 2015 23:52

initial

f942c9b

refine code and test suite

75f2342

rename test suite

c7d606d

code style

dd0aaef

code style

0015f82

Merge branch 'desc_query' of github.com:OopsOutOfMemory/spark into de…

a780539

…sc_query

refine test suite

e1da481

refine test suite

d541a35

query describe command

354ad71

OopsOutOfMemory force-pushed the desc_query branch from d541a35 to 354ad71 Compare February 2, 2015 16:14

OopsOutOfMemory added 3 commits February 4, 2015 22:53

Merge branch 'desc_query' of github.com:OopsOutOfMemory/spark into de…

68eb6dd

…sc_query

Merge branch 'master' into desc_query

aac7226

change to default argument

3ba1058

liancheng reviewed Feb 4, 2015
View reviewed changes

Update HiveOperatorQueryableSuite.scala

e71430a

style fix

OopsOutOfMemory mentioned this pull request Feb 5, 2015

[SPARK-5135][SQL] Add support for describe table to DDL in SQLContext #4227

Closed

up-to-date

6fee13d

asfgit closed this in 0b7eb3f Feb 6, 2015

[SPARK-5324][SQL] Results of describe can't be queried #4249

[SPARK-5324][SQL] Results of describe can't be queried #4249

Uh oh!

Conversation

OopsOutOfMemory commented Jan 28, 2015

Uh oh!

OopsOutOfMemory commented Jan 28, 2015

Uh oh!

AmplabJenkins commented Jan 28, 2015

Uh oh!

squito Jan 28, 2015

Choose a reason for hiding this comment

Uh oh!

rxin Feb 4, 2015

Choose a reason for hiding this comment

Uh oh!

marmbrus Jan 29, 2015

Choose a reason for hiding this comment

Uh oh!

marmbrus commented Feb 2, 2015

Uh oh!

SparkQA commented Feb 2, 2015

Uh oh!

SparkQA commented Feb 2, 2015

Uh oh!

AmplabJenkins commented Feb 2, 2015

Uh oh!

SparkQA commented Feb 2, 2015

Uh oh!

SparkQA commented Feb 2, 2015

Uh oh!

SparkQA commented Feb 2, 2015

Uh oh!

AmplabJenkins commented Feb 2, 2015

Uh oh!

SparkQA commented Feb 2, 2015

Uh oh!

AmplabJenkins commented Feb 2, 2015

Uh oh!

SparkQA commented Feb 4, 2015

Uh oh!

OopsOutOfMemory commented Feb 4, 2015

Uh oh!

SparkQA commented Feb 4, 2015

Uh oh!

AmplabJenkins commented Feb 4, 2015

Uh oh!

liancheng Feb 4, 2015

Choose a reason for hiding this comment

Uh oh!

marmbrus Feb 4, 2015

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Feb 5, 2015

Uh oh!

SparkQA commented Feb 5, 2015

Uh oh!

AmplabJenkins commented Feb 5, 2015

Uh oh!

OopsOutOfMemory commented Feb 5, 2015

Uh oh!

SparkQA commented Feb 6, 2015

Uh oh!

SparkQA commented Feb 6, 2015

Uh oh!

AmplabJenkins commented Feb 6, 2015

Uh oh!

marmbrus commented Feb 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants