Skip to content

Conversation

@LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Mar 20, 2023

What changes were proposed in this pull request?

This pr re-generates golden files for array_prepend functions. It seems that the newly added case in #38947 is missing from the golden files due to lack of rebase when merging #40449.

Why are the changes needed?

Re-generates golden files for array_prepend functions to Pass GitHub Actions

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Pass GitHub Actions
  • Manually checked with Scala 2.13

@github-actions github-actions bot added the SQL label Mar 20, 2023
@LuciferYang
Copy link
Contributor Author

cc @cloud-fan @gengliangwang @dtenedor

Copy link
Contributor

@dtenedor dtenedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!!

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs).

@LuciferYang
Copy link
Contributor Author

GA passed

@MaxGekk
Copy link
Member

MaxGekk commented Mar 20, 2023

+1, LGTM. Merging to master.
Thank you, @LuciferYang and @dongjoon-hyun @gengliangwang @dtenedor for review.

@MaxGekk MaxGekk closed this in 04333bb Mar 20, 2023
@LuciferYang
Copy link
Contributor Author

Thanks All ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants