[SPARK-39835][SQL][3.1] Fix EliminateSorts remove global sort below the local sort #37276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cal sort Correct the `EliminateSorts` follows: - If the upper sort is global then we can remove the global or local sort recursively. - If the upper sort is local then we can only remove the local sort recursively. If a global sort below locol sort, we should not remove the global sort becuase the output partitioning can be affected. This issue is going to worse since we pull out the V1 Write sort to logcial side. yes, bug fix add test Closes apache#37250 from ulysses-you/remove-sort. Authored-by: ulysses-you <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
ulysses-you
force-pushed
the
SPARK-39835-3.1
branch
from
3093d89 to
ce50b27
Compare
Contributor
Author
|
cc @cloud-fan ready for branch-3.1 |
Contributor
|
to avoid any perf regression, can we include the global sort -> repartition optimization? |
### What changes were proposed in this pull request? Optimize Global sort to RepartitionByExpression, for example: ``` Sort local Sort local Sort global => RepartitionByExpression ``` ### Why are the changes needed? If a global sort below a local sort, the only meaningful thing is it's distribution. So this pr optimizes that global sort to RepartitionByExpression to save a local sort. ### Does this PR introduce _any_ user-facing change? no, only improve performance ### How was this patch tested? add test Closes apache#37330 from ulysses-you/optimize-sort. Authored-by: ulysses-you <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Contributor
Author
|
@cloud-fan done |
Contributor
This PR does not change any python code, thus the failure is unrelated. Thanks, merging to 3.1! |
cloud-fan
pushed a commit
that referenced
this pull request
Aug 3, 2022
…he local sort backport #37250 into branch-3.1 ### What changes were proposed in this pull request? Correct the `EliminateSorts` follows: - If the upper sort is global then we can remove the global or local sort recursively. - If the upper sort is local then we can only remove the local sort recursively. ### Why are the changes needed? If a global sort below locol sort, we should not remove the global sort becuase the output partitioning can be affected. This issue is going to worse since we pull out the V1 Write sort to logcial side. ### Does this PR introduce _any_ user-facing change? yes, bug fix ### How was this patch tested? add test Closes #37276 from ulysses-you/SPARK-39835-3.1. Authored-by: ulysses-you <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #37250 into branch-3.1
What changes were proposed in this pull request?
Correct the
EliminateSortsfollows:Why are the changes needed?
If a global sort below locol sort, we should not remove the global sort becuase the output partitioning can be affected.
This issue is going to worse since we pull out the V1 Write sort to logcial side.
Does this PR introduce any user-facing change?
yes, bug fix
How was this patch tested?
add test