[SPARK-38982][PYTHON][PS][TESTS] Skip categories setter test #36355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, we added the categories setter since #33448 . |
|
Hold on this until pandas-dev/pandas#46820 (comment) |
|
Seems like they replied pandas-dev/pandas#46820 (comment). Maybe can we just close ? |
|
@itholic Now we'd better to only fix test (otherwise, will raise error when upgrade to pandas 1.4), becasue So, I suggest only fix test and keep current behavior, then remove this setter support when we remove all deprecated methods. |
|
@itholic I plus some note on code and PR descirption, and mark it read for review, thanks for reminder! |
Yikun
changed the title
HyukjinKwon
approved these changes
May 24, 2022
|
Got it! Looks good. |
itholic
approved these changes
May 25, 2022
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since pandas-dev/pandas@126a19d, pandas changes behavior.
Before pandas 1.4, the pandas will refresh dtypes according to categories, since panda 1.4,
categories.setterdtype refresh will not work. According to pandas-dev/pandas#46820 , the complete support ofcategories.setterwill never back.And also only categories is refreshed (but dtype not) is useless behavior so we'd better to only fix test and keep current PS behavior, then remove this setter support when we remove all deprecated methods.
Why are the changes needed?
Make CI passed with pandas 1.4.x
Does this PR introduce any user-facing change?
No
How was this patch tested?
test_categories_setter passed with 1.3.X and also 1.4.x