Skip to content

[SPARK-36188][PYTHON] Add categories setter to CategoricalAccessor and CategoricalIndex #33448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Jul 21, 2021

What changes were proposed in this pull request?

Add categories setter to CategoricalAccessor and CategoricalIndex.

Why are the changes needed?

We should implement categories setter in CategoricalAccessor and CategoricalIndex.

Does this PR introduce any user-facing change?

Yes, users will be able to use categories setter.

How was this patch tested?

Added some tests.

@SparkQA
Copy link

SparkQA commented Jul 21, 2021

Test build #141369 has finished for PR 33448 at commit 9e8ade5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 21, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45885/

@SparkQA
Copy link

SparkQA commented Jul 21, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45885/

@ueshin
Copy link
Member Author

ueshin commented Jul 21, 2021

The tests for pandas-on-Spark and the linter passed.
I'd merge this to master/3.2. Thanks.

@ueshin ueshin closed this in d506815 Jul 21, 2021
ueshin added a commit that referenced this pull request Jul 21, 2021
…d CategoricalIndex

### What changes were proposed in this pull request?

Add categories setter to `CategoricalAccessor` and `CategoricalIndex`.

### Why are the changes needed?

We should implement categories setter in `CategoricalAccessor` and `CategoricalIndex`.

### Does this PR introduce _any_ user-facing change?

Yes, users will be able to use categories setter.

### How was this patch tested?

Added some tests.

Closes #33448 from ueshin/issues/SPARK-36188/categories_setter.

Authored-by: Takuya UESHIN <[email protected]>
Signed-off-by: Takuya UESHIN <[email protected]>
(cherry picked from commit d506815)
Signed-off-by: Takuya UESHIN <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants