[SPARK-36194][SQL][FOLLOWUP] Propagate distinct keys more precisely #36100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @wangyum |
wangyum
approved these changes
Apr 8, 2022
wangyum
pushed a commit
that referenced
this pull request
Apr 8, 2022
### What changes were proposed in this pull request? This PR is a followup of #35779 , to propagate distinct keys more precisely in 2 cases: 1. For `LIMIT 1`, each output attribute is a distinct key, not the entire tuple. 2. For aggregate, we can still propagate distinct keys from child. ### Why are the changes needed? make the optimization cover more cases ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? new tests Closes #36100 from cloud-fan/followup. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Yuming Wang <[email protected]> (cherry picked from commit fbe82fb) Signed-off-by: Yuming Wang <[email protected]>
Member
|
Merged to master and branch-3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #35779 , to propagate distinct keys more precisely in 2 cases:
LIMIT 1, each output attribute is a distinct key, not the entire tuple.Why are the changes needed?
make the optimization cover more cases
Does this PR introduce any user-facing change?
no
How was this patch tested?
new tests