[MINOR][BUILD] Remove TODO Indentation|ImportOrder module comments from Java checkstyle.xml
#35970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed in #35949 |
LuciferYang
changed the title
TODO of Java style checkTODO of Java style check
dongjoon-hyun
approved these changes
Apr 3, 2022
dongjoon-hyun
changed the title
TODO of Java style checkTODO Indentation|ImportOrder module comments from Java checkstyle.xml
|
thanks @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are 2 TODOs in
checkstyle.xml:IndentationandImportOrder. Re enabling and fix them will involves hundreds ofJavafiles, which not worth. So this pr delete these TODOs.Why are the changes needed?
Remove Impossible
TODOof Java style checkDoes this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA