Skip to content

[SPARK-32165][SQL] Ensure Spark only initiates SharedState once across SparkSessions #35224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vinooganesh wants to merge 1 commit into from
Closed

[SPARK-32165][SQL] Ensure Spark only initiates SharedState once across SparkSessions #35224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ private[sql] class SharedState(
* A status store to query SQL status/metrics of this Spark application, based on SQL-specific
* [[org.apache.spark.scheduler.SparkListenerEvent]]s.
*/
val statusStore: SQLAppStatusStore = {
lazy val statusStore: SQLAppStatusStore = {
val kvStore = sparkContext.statusStore.store.asInstanceOf[ElementTrackingStore]
val listener = new SQLAppStatusListener(conf, kvStore, live = true)
sparkContext.listenerBus.addToStatusQueue(listener)
Expand Down
29 changes: 29 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/SparkSessionBuilderSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,35 @@ class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach wit
SparkSession.clearActiveSession()
SparkSession.clearDefaultSession()
assert(postFirstCreation == postSecondCreation)
context.stop()
}

test("SPARK-32165: Ensure Spark only initiates SharedState once across SparkSessions") {
val conf = new SparkConf()
.setMaster("local")
.setAppName("test-app-SPARK-32165-1")
val context = new SparkContext(conf)
SparkSession
.builder()
.master("local")
.getOrCreate()
.sessionState // this touches the sessionState
val postFirstCreation = context.listenerBus.listeners.size()
SparkSession.clearActiveSession()
SparkSession.clearDefaultSession()

SparkSession
.builder()
.sparkContext(context)
.master("local")
.getOrCreate()
.sessionState // this touches the sessionState
val postSecondCreation = context.listenerBus.listeners.size()
SparkSession.clearActiveSession()
SparkSession.clearDefaultSession()

// minus 1 to account for ExecutionListenerBus
assert(postFirstCreation == postSecondCreation - 1)
}

test("SPARK-31532: should not propagate static sql configs to the existing" +
Expand Down