-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-37018][SQL] Spark SQL should support create function with Aggregator #34352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reference for the code above? The code looks obscure
sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few more stuff I'd like to test:
- What if the class has type parameters? e.g.
class TypedCount[IN](val f: IN => Any) extends Aggregator[IN, Long, Long]. What happens if we register it as a SQL UDAF? - Let's test negative cases, e.g., wrong num of parameters, wrong parameter types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the type parameter will be
IN, we need find another way.
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #144497 has finished for PR 34352 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #145357 has finished for PR 34352 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #145387 has finished for PR 34352 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #145383 has finished for PR 34352 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #145393 has finished for PR 34352 at commit
|
…ionStateBuilder.scala Co-authored-by: Wenchen Fan <[email protected]>
61d9614 to
e742552
Compare
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Kubernetes integration test starting |
|
Test build #146513 has finished for PR 34352 at commit
|
|
Kubernetes integration test status failure |
|
Test build #146528 has finished for PR 34352 at commit
|
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
|
@beliefer Hi, is there any progress on this? |
What changes were proposed in this pull request?
Spark SQL not supports to create function of
Aggregatoryet and deprecatedUserDefinedAggregateFunction.If we want remove
UserDefinedAggregateFunction, Spark SQL should provide a new option.Note: This PR replaces #34303.
Why are the changes needed?
We need to provide a new way to create user defined aggregate function so as remove
UserDefinedAggregateFunctionin future.Does this PR introduce any user-facing change?
Yes. Users will create user defined aggregate function by implement
Aggregator.How was this patch tested?
New tests.