Skip to content

Conversation

@gengliangwang
Copy link
Member

@gengliangwang gengliangwang commented Aug 19, 2021

What changes were proposed in this pull request?

When preparing Spark 3.2.0 RC1, I hit the same issue of #31031.

[INFO] Compiling 21 Scala sources and 3 Java sources to /opt/spark-rm/output/spark-3.1.0-bin-hadoop2.7/resource-managers/yarn/target/scala-2.12/test-classes ...
[ERROR] ## Exception when compiling 24 sources to /opt/spark-rm/output/spark-3.1.0-bin-hadoop2.7/resource-managers/yarn/target/scala-2.12/test-classes
java.lang.SecurityException: class "javax.servlet.SessionCookieConfig"'s signer information does not match signer information of other classes in the same package
java.lang.ClassLoader.checkCerts(ClassLoader.java:891)
java.lang.ClassLoader.preDefineClass(ClassLoader.java:661)

This PR is to apply the same fix again by downgrading scala-maven-plugin to 4.3.0

Why are the changes needed?

To unblock the release process.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Build test

@gengliangwang
Copy link
Member Author

I am still trying the fix with ./dev/create-release/do-release-docker.sh. It will probably work just like #31031.

@cloud-fan
Copy link
Contributor

@SparkQA
Copy link

SparkQA commented Aug 19, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47150/

@SparkQA
Copy link

SparkQA commented Aug 19, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47150/

@dongjoon-hyun
Copy link
Member

Oh. Thank you for pinging me, @cloud-fan and @gengliangwang .

<artifactId>scala-maven-plugin</artifactId>
<version>4.5.3</version>
<!-- SPARK-36547: Please don't upgrade the version below, otherwise there will be an error on building Hadoop 2.7 package -->
<version>4.3.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. I forgot the history. :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries .. It was only able to reproduce in some specific environments. I don't think there was anything wrong when we upgrade.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, ideally it should be investigated why it fails in the specific environments .. but I am fine to unblock the release for now.

@gengliangwang
Copy link
Member Author

Merging to master/3.2

gengliangwang added a commit that referenced this pull request Aug 20, 2021
### What changes were proposed in this pull request?

When preparing Spark 3.2.0 RC1, I hit the same issue of #31031.
```
[INFO] Compiling 21 Scala sources and 3 Java sources to /opt/spark-rm/output/spark-3.1.0-bin-hadoop2.7/resource-managers/yarn/target/scala-2.12/test-classes ...
[ERROR] ## Exception when compiling 24 sources to /opt/spark-rm/output/spark-3.1.0-bin-hadoop2.7/resource-managers/yarn/target/scala-2.12/test-classes
java.lang.SecurityException: class "javax.servlet.SessionCookieConfig"'s signer information does not match signer information of other classes in the same package
java.lang.ClassLoader.checkCerts(ClassLoader.java:891)
java.lang.ClassLoader.preDefineClass(ClassLoader.java:661)
```
This PR is to apply the same fix again by downgrading scala-maven-plugin to 4.3.0

### Why are the changes needed?

To unblock the release process.

### Does this PR introduce _any_ user-facing change?

No
### How was this patch tested?

Build test

Closes #33791 from gengliangwang/downgrade.

Authored-by: Gengliang Wang <[email protected]>
Signed-off-by: Gengliang Wang <[email protected]>
(cherry picked from commit f0775d2)
Signed-off-by: Gengliang Wang <[email protected]>
@SparkQA
Copy link

SparkQA commented Aug 20, 2021

Test build #142649 has finished for PR 33791 at commit 9ad5f55.

  • This patch fails from timeout after a configured wait of 500m.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants