[SPARK-36380][SQL] Simplify the logical plan names for ALTER TABLE ... COLUMN #33609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #141952 has finished for PR 33609 at commit
|
imback82
approved these changes
Aug 2, 2021
Contributor
imback82
left a comment
imback82
left a comment
There was a problem hiding this comment.
LGTM, thanks @cloud-fan!
|
Test build #141951 has finished for PR 33609 at commit
|
MaxGekk
approved these changes
Aug 3, 2021
Member
|
+1, LGTM. Merging to master and to 3.2 (as it is follow up of adding logical plans that haven't released yet). |
MaxGekk
pushed a commit
that referenced
this pull request
Aug 3, 2021
…. COLUMN ### What changes were proposed in this pull request? This a followup of the recent work such as #33200 For `ALTER TABLE` commands, the logical plans do not have the common `AlterTable` prefix in the name and just use names like `SetTableLocation`. This PR proposes to follow the same naming rule in `ALTER TABE ... COLUMN` commands. This PR also moves these AlterTable commands to a individual file and give them a base trait. ### Why are the changes needed? name simplification ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing test Closes #33609 from cloud-fan/dsv2. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Max Gekk <[email protected]> (cherry picked from commit 7cb9c1c) Signed-off-by: Max Gekk <[email protected]>
LuciferYang
pushed a commit
that referenced
this pull request
Aug 1, 2024
…r's` comments ### What changes were proposed in this pull request? The pr aims to fix the outdated `logical plan name` in `AstBuilder's` comments. ### Why are the changes needed? - After the pr #33609, the name of the logical plan below has been changed: `AlterTableAddColumns` -> `AddColumns` `AlterTableRenameColumn` -> `RenameColumn` `AlterTableAlterColumn` -> `AlterColumn` `AlterTableDropColumns` -> `DropColumns` - After the pr #30398 The name of the logical plan `ShowPartitionsStatement` has been changed to `ShowPartitions`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Only update comments. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47562 from panbingkun/fix_astbuilder. Lead-authored-by: panbingkun <[email protected]> Co-authored-by: panbingkun <[email protected]> Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This a followup of the recent work such as #33200
For
ALTER TABLEcommands, the logical plans do not have the commonAlterTableprefix in the name and just use names likeSetTableLocation. This PR proposes to follow the same naming rule inALTER TABE ... COLUMNcommands.This PR also moves these AlterTable commands to a individual file and give them a base trait.
Why are the changes needed?
name simplification
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing test