[SPARK-34952][SQL][FOLLOWUP] Simplify JDBC aggregate pushdown #33579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
huaxingao
reviewed
Jul 29, 2021
| case agg: AggregateExpression => agg | ||
| // Do not push down duplicated aggregate expressions. For example, | ||
| // `SELECT max(a) + 1, max(a) + 2 FROM ...`, we should only push down one | ||
| // `sum(a)` to the data source. |
Contributor
|
java linter failed because of Thanks a lot for improving the code! Really appreciate your help! |
huaxingao
approved these changes
Jul 29, 2021
viirya
reviewed
Jul 29, 2021
| - JDBCOptions.JDBC_UPPER_BOUND + | ||
| (JDBCOptions.JDBC_QUERY_STRING -> aggQuery)) | ||
| try { | ||
| finalSchema = JDBCRDD.resolveTable(jdbcOptionsWithAggQuery) |
viirya
approved these changes
Jul 29, 2021
|
Test build #141848 has finished for PR 33579 at commit
|
viirya
approved these changes
Jul 30, 2021
Member
|
CI pending. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Member
|
Thanks. Merging master/3.2. |
viirya
pushed a commit
that referenced
this pull request
Jul 30, 2021
### What changes were proposed in this pull request? This is a followup of #33352 , to simplify the JDBC aggregate pushdown: 1. We should get the schema of the aggregate query by asking the JDBC server, instead of calculating it by ourselves. This can simplify the code a lot, and is also more robust: the data type of SUM may vary in different databases, it's fragile to assume they are always the same as Spark. 2. because of 1, now we can remove the `dataType` property from the public `Sum` expression. This PR also contains some small improvements: 1. Spark should deduplicate the aggregate expressions before pushing them down. 2. Improve the `toString` of public aggregate expressions to make them more SQL. ### Why are the changes needed? code and API simplification ### Does this PR introduce _any_ user-facing change? this API is not released yet. ### How was this patch tested? existing tests Closes #33579 from cloud-fan/dsv2. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]> (cherry picked from commit 387a251) Signed-off-by: Liang-Chi Hsieh <[email protected]>
|
Test build #141871 has finished for PR 33579 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #33352 , to simplify the JDBC aggregate pushdown:
dataTypeproperty from the publicSumexpression.This PR also contains some small improvements:
toStringof public aggregate expressions to make them more SQL.Why are the changes needed?
code and API simplification
Does this PR introduce any user-facing change?
this API is not released yet.
How was this patch tested?
existing tests