Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 5, 2020

What changes were proposed in this pull request?

This PR fixes incorrect JIRA ids in Analyzer.scala introduced by SPARK-31670 (#28490)

- // SPARK-31607: Resolve Struct field in selectedGroupByExprs/groupByExprs and aggregations
+ // SPARK-31670: Resolve Struct field in selectedGroupByExprs/groupByExprs and aggregations

Why are the changes needed?

Fix the wrong information.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

This is a comment change. Manually review.

@github-actions github-actions bot added the SQL label Nov 5, 2020
@dongjoon-hyun
Copy link
Member Author

cc @AngersZhuuuu and @cloud-fan

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Nov 5, 2020

I made this as a MINOR PR because it's too late to make a follow-up (The original PR was merged early September).
If you guys want, we can make this as a follow-up.

@SparkQA
Copy link

SparkQA commented Nov 6, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35286/

@SparkQA
Copy link

SparkQA commented Nov 6, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35286/

@dongjoon-hyun dongjoon-hyun changed the title [MINOR][SQL] Fix incorrect JIRA ids comment in Analyzer [MINOR][SQL] Fix incorrect JIRA ID comments in Analyzer Nov 6, 2020
@HyukjinKwon
Copy link
Member

Merged to master.

@SparkQA
Copy link

SparkQA commented Nov 6, 2020

Test build #130675 has finished for PR 30269 at commit 36779a4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Nov 6, 2020

lgtm

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon and @maropu .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-31670-MINOR branch November 6, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants