Renamed stageIdToActiveJob to jobIdToActiveJob. #301
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This data structure was misnamed and, as a result, misused.
|
Merged build triggered. |
|
Merged build started. |
Contributor
|
lgtm |
1 similar comment
Contributor
|
lgtm |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
Contributor
|
good catch |
Contributor
|
Thanks, merged. |
Contributor
|
Yes, good catch. This isn't the first confusion/conflation of jobId and stageId within the DAGScheduler and TaskManager, so it is something to keep a sharp eye on. This renaming should make future such mistakes less likely, so it LGTMT. |
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
This data structure was misused and, as a result, later renamed to an incorrect name. This data structure seems to have gotten into this tangled state as a result of @henrydavidge using the stageID instead of the job Id to index into it and later @andrewor14 renaming the data structure to reflect this misunderstanding. This patch renames it and removes an incorrect indexing into it. The incorrect indexing into it meant that the code added by @henrydavidge to warn when a task size is too large (added here apache@5757993) was not always executed; this commit fixes that. Author: Kay Ousterhout <[email protected]> Closes apache#301 from kayousterhout/fixCancellation and squashes the following commits: bd3d3a4 [Kay Ousterhout] Renamed stageIdToActiveJob to jobIdToActiveJob.
lins05
pushed a commit
to lins05/spark
that referenced
this pull request
May 30, 2017
* Add proxy configuration to retrofit clients. * Add logging
erikerlandson
pushed a commit
to erikerlandson/spark
that referenced
this pull request
Jul 28, 2017
* Add proxy configuration to retrofit clients. * Add logging
gatesn
pushed a commit
to gatesn/spark
that referenced
this pull request
Mar 14, 2018
Small upstream merge
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Sep 12, 2019
….3.2 take bindAddress as input
arjunshroff
pushed a commit
to arjunshroff/spark
that referenced
this pull request
Nov 24, 2020
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This data structure was misused and, as a result, later renamed to an incorrect name.
This data structure seems to have gotten into this tangled state as a result of @henrydavidge using the stageID instead of the job Id to index into it and later @andrewor14 renaming the data structure to reflect this misunderstanding.
This patch renames it and removes an incorrect indexing into it. The incorrect indexing into it meant that the code added by @henrydavidge to warn when a task size is too large (added here 5757993) was not always executed; this commit fixes that.