[SPARK-32713][K8S] Support execId placeholder in executor PVC conf #29557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-c spark.kubernetes.executor.volumes.persistentVolumeClaim.spark-local-dir-1.options.claimName=pvc-spark-SPARK_EXECUTOR_ID \ -c spark.kubernetes.executor.volumes.persistentVolumeClaim.spark-local-dir-1.mount.path=/data \ -c spark.kubernetes.executor.volumes.persistentVolumeClaim.spark-local-dir-1.mount.readOnly=false \
|
Test build #127953 has finished for PR 29557 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
Member
Author
Contributor
|
LGTM |
Contributor
|
Maybe consider a follow up to document this? |
Member
Author
|
Thanks. Sure! I have two related PRs. I'll make a K8s doc PR. |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Oct 27, 2020
### What changes were proposed in this pull request? This PR aims to support executor id placeholder in `spark.kubernetes.executor.volumes.persistentVolumeClaim.myname.options.claimName` configuration like the following. ``` --conf spark.kubernetes.executor.volumes.persistentVolumeClaim.spark-local-dir-1.options.claimName=pvc-spark-SPARK_EXECUTOR_ID \ ``` ### Why are the changes needed? This is a convenient way to mount corresponding PV to the executor. ### Does this PR introduce _any_ user-facing change? Yes, but this is a new feature and there is no regression because users don't use `SPARK_EXECUTOR_ID` in PVC claim name. ### How was this patch tested? Pass the newly added test case. Closes apache#29557 from dongjoon-hyun/SPARK-PVC. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 8, 2022
…dynamic allocation failure ### What changes were proposed in this pull request? This PR aims to show a directional error message for executor PVC dynamic allocation failure. ### Why are the changes needed? #29846 supports dynamic PVC creation/deletion for K8s executors. #29557 support execId placeholder in executor PVC conf. If not set `spark.kubernetes.executor.volumes.persistentVolumeClaim.spark-local-dir-1.options.claimName` with `onDemand` or `SPARK_EXECUTOR_ID`, spark will continue to try to create the executor pod. After this PR, spark can show a directional error message for this situation. ```plain ERROR ExecutorPodsSnapshotsStoreImpl: Going to stop due to IllegalArgumentException java.lang.IllegalArgumentException: PVC ClaimName should contain OnDemand or SPARK_EXECUTOR_ID when multiple executors are required ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add unit test. Closes #36374 from dcoliversun/SPARK-39006. Authored-by: Qian.Sun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support executor id placeholder in
spark.kubernetes.executor.volumes.persistentVolumeClaim.myname.options.claimNameconfiguration like the following.Why are the changes needed?
This is a convenient way to mount corresponding PV to the executor.
Does this PR introduce any user-facing change?
Yes, but this is a new feature and there is no regression because users don't use
SPARK_EXECUTOR_IDin PVC claim name.How was this patch tested?
Pass the newly added test case.