-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-32524][SQL][TESTS] CachedBatchSerializerSuite should clean up InMemoryRelation.ser #29346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…InMemoryRelation.ser
|
cc @cloud-fan, @HyukjinKwon , @revans2 , @tgravescs |
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I prefer this way but don't feel strongly if other people prefer the other way.
...core/src/test/scala/org/apache/spark/sql/execution/columnar/CachedBatchSerializerSuite.scala
Show resolved
Hide resolved
|
Thank you for reiview and approval, @HyukjinKwon . |
|
Thanks, @cloud-fan . |
|
Test build #127030 has finished for PR 29346 at commit
|
|
Test build #127033 has finished for PR 29346 at commit
|
|
Test build #127032 has finished for PR 29346 at commit
|
|
retest this please |
|
I am going to merge this since GitHub Actions builds passed. |
|
Test build #127044 has finished for PR 29346 at commit
|
|
Thank you, @cloud-fan and @HyukjinKwon . |
|
Thanks for finding and fixing this for me. |
|
Thanks, @revans2 ! :) |
What changes were proposed in this pull request?
This PR aims to clean up
InMemoryRelation.serinCachedBatchSerializerSuite.Why are the changes needed?
SPARK-32274 makes SQL cache serialization pluggable.
This causes UT failures.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually.