[SPARK-24634][SS][FOLLOWUP] Rename the variable from "numLateInputs" to "numRowsDroppedByWatermark" #28828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to "numDropppedRowsByWatermark"
Contributor
Author
|
cc. @zsxwing |
|
Test build #124013 has finished for PR 28828 at commit
|
|
Test build #124017 has finished for PR 28828 at commit
|
|
Test build #124015 has finished for PR 28828 at commit
|
Member
|
@xuanyuanking too FYI |
xuanyuanking
approved these changes
Jun 15, 2020
Member
xuanyuanking
left a comment
xuanyuanking
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick follow-up.
HyukjinKwon
approved these changes
Jun 15, 2020
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Looks good to me too. I will merge in few days.
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala
Outdated
Show resolved
Hide resolved
HeartSaVioR
changed the title
|
Test build #124040 has finished for PR 28828 at commit
|
zsxwing
reviewed
Jun 15, 2020
Member
zsxwing
left a comment
zsxwing
left a comment
There was a problem hiding this comment.
Left one minor comment. Otherwise LGTM. Thanks for fixing this!
|
Test build #124073 has finished for PR 28828 at commit
|
|
Test build #124074 has finished for PR 28828 at commit
|
Member
|
Merged to master. |
Contributor
Author
|
Thanks all for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR renames the variable from "numLateInputs" to "numRowsDroppedByWatermark" so that it becomes self-explanation.
Why are the changes needed?
This is originated from post-review, see #28607 (comment)
Does this PR introduce any user-facing change?
No, as SPARK-24634 is not introduced in any release yet.
How was this patch tested?
Existing UTs.