[SPARK-31905][SS] Add compatibility tests for streaming state store format #28725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #123524 has finished for PR 28725 at commit
|
xuanyuanking
changed the title
|
Test build #124127 has finished for PR 28725 at commit
|
xuanyuanking
commented
Jun 17, 2020
| ) | ||
| } | ||
|
|
||
| test("deduplicate with all columns") { |
Member
Author
There was a problem hiding this comment.
cc @maropu @dongjoon-hyun
This new integrated test will return the wrong answer without #28830.
xuanyuanking
force-pushed
the
compatibility_check
branch
from
f311e82 to
9ad2c06
Compare
Member
Author
|
#28707 has been merged, these integration tests are ready for review. |
xuanyuanking
changed the title
cloud-fan
approved these changes
Jun 19, 2020
|
Test build #124276 has finished for PR 28725 at commit
|
Contributor
|
thanks, merging to master! |
Member
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add compatibility tests for streaming state store format.
Why are the changes needed?
After SPARK-31894, we have a validation checking for the streaming state store. It's better to add integrated tests in the PR builder as soon as the breaking changes introduced.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Test only.