SPARK-1365 [HOTFIX] Fix RateLimitedOutputStream test #277
Conversation
|
How about just making sure it has a lower bound of 4? |
|
Merged build triggered. Build is starting -or- tests failed to complete. |
|
Merged build started. Build is starting -or- tests failed to complete. |
|
rate limiting was about setting an upper bound in throughput, and thus lower bound in time. |
|
Merged build finished. Build is starting -or- tests failed to complete. |
|
Build is starting -or- tests failed to complete. |
|
@rxin true, but that's like saying an eventual consistency implementation that never converges is okay. I.e. we want to test that it isn't just a no-op stream that never passes data through. |
|
@rxin I'll just add a conservative upper bound also to make sure it does eventually get through. |
pwendell
changed the title
This test needs to be fixed. It currently depends on Thread.sleep() having exact-timing semantics, which is not a valid assumption.
|
Merged build triggered. Build is starting -or- tests failed to complete. |
|
Merged build started. Build is starting -or- tests failed to complete. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
This test needs to be fixed. It currently depends on Thread.sleep() having exact-timing semantics, which is not a valid assumption. Author: Patrick Wendell <[email protected]> Closes apache#277 from pwendell/rate-limited-stream and squashes the following commits: 6c0ff81 [Patrick Wendell] SPARK-1365: Fix RateLimitedOutputStream test
* MapR [SPARK-226] Spark - pySpark Security Vulnerability
3 participants
This test needs to be fixed. It currently depends on Thread.sleep() having exact-timing
semantics, which is not a valid assumption.