Skip to content

Conversation

@dbtsai
Copy link
Member

@dbtsai dbtsai commented Oct 8, 2014

spark-defaults.conf is used in spark-shell as well, and this PR added this into the comment.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have started for PR 2709 at commit b3e1ff1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 8, 2014

QA tests have finished for PR 2709 at commit b3e1ff1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21457/Test PASSed.

@andrewor14
Copy link
Contributor

Well, spark-shell (and pyspark) goes through spark-submit. Actually as of a recent PR (#2379) that will be merged soon, this file will be used for other Spark daemons too (Worker, Master, HistoryServer...). Once that's merged we should generalize this comment to reflect that.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@andrewor14
Copy link
Contributor

Hey @dbtsai can you update this now that #2379 has gone in? In particular this is now used by the Spark daemons too (i.e. Worker, Master, HistoryServer). I'm don't feel strongly about commenting that this applies to spark-shell and pyspark one way or the other. If you're occupied with other things I can also take this over if you wish.

@dbtsai
Copy link
Member Author

dbtsai commented Oct 19, 2014

@andrewor14 Sorry for late reply since I was on vacation in Europe last week. I can continue work on this after I finish my talk in IOTA conf tomorrow.

@dbtsai dbtsai closed this Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants