Skip to content

[SPARK-29378][R][FOLLOW-UP] Remove manual installation of Arrow dependencies in AppVeyor build #26566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[SPARK-29378][R][FOLLOW-UP] Remove manual installation of Arrow dependencies in AppVeyor build #26566

HyukjinKwon wants to merge 1 commit into from

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Nov 18, 2019

What changes were proposed in this pull request?

This PR remove manual installation of Arrow dependencies in AppVeyor build

Why are the changes needed?

It's unnecessary. See #26555 (comment)

Does this PR introduce any user-facing change?

No

How was this patch tested?

AppVeyor will test.

@HyukjinKwon HyukjinKwon mentioned this pull request Nov 18, 2019
Closed
dongjoon-hyun
dongjoon-hyun approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. (Pending AppVeyor)
Thank you, @HyukjinKwon .

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Nov 18, 2019 •
edited
Loading

Hm, I am not sure why AppVeyor isn't running. It's in:

only_commits:
  files:
    - appveyor.yml
...

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Nov 18, 2019

It's triggered, @HyukjinKwon ~

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Nov 18, 2019

Please see

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Nov 18, 2019 •
edited
Loading

Screen Shot 2019-11-17 at 7 49 51 PM

Please note the 5 successful checks. You can scroll down the UI and see AppVeyor.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Nov 18, 2019

Screen Shot 2019-11-17 at 7 52 28 PM

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Nov 18, 2019

Oops. thanks

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Nov 18, 2019

Merged to master.

@SparkQA
Copy link

SparkQA commented Nov 18, 2019

Test build #113977 has finished for PR 26566 at commit d8e8d32.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 18, 2019

Test build #113981 has finished for PR 26566 at commit f7918d3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon deleted the SPARK-29378 branch March 3, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

SPARKR TESTS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HyukjinKwon @dongjoon-hyun @SparkQA