[MINOR][INFRA] Change the Github Actions build command to mvn install
#26414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
mvn installmvn install
dongjoon-hyun
approved these changes
Nov 6, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. This improves our test coverage (Maven install step).
Member
|
Merged to master/2.4. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 6, 2019
This PR change the Github Actions build command from `mvn package` to `mvn install` to build Scaladoc jars. Sometimes `mvn install` build failure with error: `not found: type ClassName...`. More details: #24628 (comment) No. N/A Closes #26414 from wangyum/github-action-install. Authored-by: Yuming Wang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit e5c176a) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Test build #113334 has finished for PR 26414 at commit
|
scunniff
pushed a commit
to scunniff/nomad-spark
that referenced
this pull request
Nov 10, 2020
This PR change the Github Actions build command from `mvn package` to `mvn install` to build Scaladoc jars. Sometimes `mvn install` build failure with error: `not found: type ClassName...`. More details: apache#24628 (comment) No. N/A Closes apache#26414 from wangyum/github-action-install. Authored-by: Yuming Wang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit e5c176a) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR change the Github Actions build command from
mvn packagetomvn installto build Scaladoc jars.Why are the changes needed?
Sometimes
mvn installbuild failure with error:not found: type ClassName....More details: #24628 (comment)
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A