[SPARK-28938][K8S][2.4][FOLLOWUP] Use /usr/bin/tini instead of /sbin/tini
#26296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bernetes fix entrypoint The pass through feature of the entrypoint.sh script needs to change from /sbin/tini => /usr/bin/tini
Member
|
ok to test |
viirya
reviewed
Oct 29, 2019
| *) | ||
| echo "Non-spark-on-k8s command provided, proceeding in pass-through mode..." | ||
| exec /sbin/tini -s -- "$@" | ||
| exec /usr/bin/tini -s -- "$@" |
Member
viirya
approved these changes
Oct 29, 2019
Member
|
@jkleckner The JIRA number in the title seems wrong, can you fix it? Please also modify the title to make it not truncated. |
|
Kubernetes integration test starting |
|
Test build #112856 has finished for PR 26296 at commit
|
|
Kubernetes integration test status success |
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
/usr/bin/tini instead of /sbin/tini
Member
|
Thank you for the followup, @jkleckner and @viirya . |
dongjoon-hyun
changed the title
/usr/bin/tini instead of /sbin/tini/usr/bin/tini instead of /sbin/tini
dongjoon-hyun
approved these changes
Oct 29, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to branch-2.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Oct 29, 2019
…in/tini` ### What changes were proposed in this pull request? Change entrypoint.sh script for the kubernetes manager image to reference /usr/sbin/tini ### Why are the changes needed? This makes running commands like /bin/bash via pass-through work. This was missing from #26046 ### Does this PR introduce any user-facing change? It makes pass-through work. ### How was this patch tested? I built an image and verified that the following worked: `docker run -it --rm image:version /bin/bash` Closes #26296 from jkleckner/fix-pass-through-38938. Authored-by: Jim Kleckner <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Thank you for the followup, @jkleckner and @viirya . |
Author
|
Wow, thanks for the fast action! |
jkleckner
pushed a commit
to jkleckner/spark-on-k8s-operator
that referenced
this pull request
Dec 6, 2019
As outlined in kubeflow#669 this is needed to run properly because it includes the unreleased fixes from apache/spark#26046 and apache/spark#26296 which are needed for GKE authentication to work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change entrypoint.sh script for the kubernetes manager image to reference /usr/sbin/tini
Why are the changes needed?
This makes running commands like /bin/bash via pass-through work.
This was missing from #26046
Does this PR introduce any user-facing change?
It makes pass-through work.
How was this patch tested?
I built an image and verified that the following worked:
docker run -it --rm image:version /bin/bash