Skip to content

Conversation

@gatorsmile
Copy link
Member

@gatorsmile gatorsmile commented Sep 3, 2019

What changes were proposed in this pull request?

This PR is to upgrade the maven dependence from 3.6.1 to 3.6.2.

Why are the changes needed?

All the builds are broken because 3.6.1 is not available. http://ftp.wayne.edu/apache//maven/maven-3/

image

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A

@gatorsmile gatorsmile requested review from dongjoon-hyun and srowen and removed request for srowen September 3, 2019 17:55
@gatorsmile
Copy link
Member Author

cc @zsxwing

@gatorsmile gatorsmile changed the title [HOT-FIX][BUILD] Upgrade Maven from 3.6.1 to 3.6.2 [HOT-FIX][SPARK-28961][BUILD] Upgrade Maven from 3.6.1 to 3.6.2 Sep 3, 2019
@zsxwing
Copy link
Member

zsxwing commented Sep 3, 2019

@gatorsmile have you tried locally? If it passes locally, we can just merge this. The worst case is master is still broken.

@gatorsmile
Copy link
Member Author

image

@gatorsmile
Copy link
Member Author

It already passed.

@gatorsmile
Copy link
Member Author

Let me merge it now

@gatorsmile gatorsmile closed this in 2856398 Sep 3, 2019
@srowen
Copy link
Member

srowen commented Sep 3, 2019

It's fine to update Maven, so this is OK.

The problem is really that mirrors are only supposed to host the latest releases, and that's what build/mvn is checking. It doesn't fall back to https://archive.apache.org/dist/maven/maven-3/3.6.1/binaries/ for example, where all releases are still held.

It's a good idea to use mirrors of course. Hm, but that's going to be a problem for anyone using previous releases that refer to maintenance releases that go away from the mirror. I'll put something together to try to fall back to archive.apache.org

@dongjoon-hyun
Copy link
Member

Thank you for the quick fix, @gatorsmile .

@srowen
Copy link
Member

srowen commented Sep 3, 2019

See #25667 for a change that should help avoid this going forward.

@SparkQA
Copy link

SparkQA commented Sep 3, 2019

Test build #110049 has finished for PR 25665 at commit dc39d0d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants