-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28354][INFRA] Use JIRA user name instead of JIRA user key #25120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #107553 has finished for PR 25120 at commit
|
|
Retest this please. |
|
Sure, if it works better that's good. I consistently get a failure when assigning JIRAs to Yuming Wang -- have you seen that too? maybe this fixes it. |
|
Yes. Right. That's the exact reason for this fix. I also hit the failures during merging his PRs. :D |
|
Test build #107556 has finished for PR 25120 at commit
|
|
Yea .. get the failure to Yuming Wang too .. |
|
@wangyum, this PR is for you. hahaha |
|
Merged to master. |
|
Thank you @dongjoon-hyun @srowen @HyukjinKwon |
|
Thank you all! |
## What changes were proposed in this pull request? `dev/merge_spark_pr.py` script always fail for some users because they have different `name` and `key`. - https://issues.apache.org/jira/rest/api/2/user?username=yumwang JIRA Client expects `name`, but we are using `key`. This PR fixes it. ```python # This is JIRA client code `/usr/local/lib/python2.7/site-packages/jira/client.py` def assign_issue(self, issue, assignee): """Assign an issue to a user. None will set it to unassigned. -1 will set it to Automatic. :param issue: the issue ID or key to assign :param assignee: the user to assign the issue to :type issue: int or str :type assignee: str :rtype: bool """ url = self._options['server'] + \ '/rest/api/latest/issue/' + str(issue) + '/assignee' payload = {'name': assignee} r = self._session.put( url, data=json.dumps(payload)) raise_on_error(r) return True ``` ## How was this patch tested? Manual with the committer ID/password. ```python import jira.client asf_jira = jira.client.JIRA({'server': 'https://issues.apache.org/jira'}, basic_auth=('yourid', 'passwd')) asf_jira.assign_issue("SPARK-28354", "q79969786") # This will raise exception. asf_jira.assign_issue("SPARK-28354", "yumwang") # This works. ``` Closes apache#25120 from dongjoon-hyun/SPARK-28354. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
What changes were proposed in this pull request?
dev/merge_spark_pr.pyscript always fail for some users because they have differentnameandkey.JIRA Client expects
name, but we are usingkey. This PR fixes it.How was this patch tested?
Manual with the committer ID/password.